Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add benchmark for roundtrip of 100 large WebSocket messages #9645

Merged
merged 2 commits into from
Nov 3, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Nov 3, 2024

SSIA

For testing if #9634 is viable

Looks like almost all the overhead is memcpy

@bdraco bdraco requested a review from asvetlov as a code owner November 3, 2024 06:35
@bdraco bdraco added bot:chronographer:skip This PR does not need to include a change note backport-3.10 backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot labels Nov 3, 2024
@bdraco
Copy link
Member Author

bdraco commented Nov 3, 2024

Will need to tweak it a bit for 3.10

Copy link

codspeed-hq bot commented Nov 3, 2024

CodSpeed Performance Report

Merging #9645 will not alter performance

Comparing large_ws_message_roundtrip (4f251a2) with master (70a2c34)

Summary

✅ 10 untouched benchmarks

🆕 1 new benchmarks

Benchmarks breakdown

Benchmark master large_ws_message_roundtrip Change
🆕 test_one_thousand_large_round_trip_websocket_text_messages[pyloop] N/A 32.6 ms N/A

@bdraco bdraco enabled auto-merge (squash) November 3, 2024 07:12
Copy link

codecov bot commented Nov 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.64%. Comparing base (70a2c34) to head (4f251a2).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9645   +/-   ##
=======================================
  Coverage   98.64%   98.64%           
=======================================
  Files         115      115           
  Lines       35395    35417   +22     
  Branches     4196     4199    +3     
=======================================
+ Hits        34916    34938   +22     
  Misses        321      321           
  Partials      158      158           
Flag Coverage Δ
CI-GHA 98.53% <100.00%> (+<0.01%) ⬆️
OS-Linux 98.20% <100.00%> (+<0.01%) ⬆️
OS-Windows 96.11% <100.00%> (+<0.01%) ⬆️
OS-macOS 97.42% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 97.28% <100.00%> (+<0.01%) ⬆️
Py-3.10.15 97.68% <100.00%> (+<0.01%) ⬆️
Py-3.11.10 97.76% <100.00%> (+<0.01%) ⬆️
Py-3.11.9 97.35% <100.00%> (-0.01%) ⬇️
Py-3.12.7 98.23% <100.00%> (+<0.01%) ⬆️
Py-3.13.0 98.22% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 97.19% <100.00%> (-0.01%) ⬇️
Py-3.9.20 97.59% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.16 97.21% <100.00%> (+<0.01%) ⬆️
VM-macos 97.42% <100.00%> (+<0.01%) ⬆️
VM-ubuntu 98.20% <100.00%> (+<0.01%) ⬆️
VM-windows 96.11% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco merged commit 541b149 into master Nov 3, 2024
37 of 38 checks passed
@bdraco bdraco deleted the large_ws_message_roundtrip branch November 3, 2024 07:30
Copy link
Contributor

patchback bot commented Nov 3, 2024

Backport to 3.10: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.10/541b14965b81363c2ee3c5e2030333fb5bd4565d/pr-9645

Backported as #9647

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

Copy link
Contributor

patchback bot commented Nov 3, 2024

Backport to 3.11: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.11/541b14965b81363c2ee3c5e2030333fb5bd4565d/pr-9645

Backported as #9648

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Nov 3, 2024
bdraco added a commit that referenced this pull request Nov 3, 2024
… large WebSocket messages (#9647)

Co-authored-by: J. Nick Koston <[email protected]>
bdraco added a commit that referenced this pull request Nov 3, 2024
… large WebSocket messages (#9648)

Co-authored-by: J. Nick Koston <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant