Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump yarl to 1.17.1 #9655

Merged
merged 1 commit into from
Nov 3, 2024
Merged

Bump yarl to 1.17.1 #9655

merged 1 commit into from
Nov 3, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Nov 3, 2024

Doing this ahead of dependabot to see what the performance impact is

Doing this ahead of dependabot to see what the performance impact is
@bdraco bdraco added bot:chronographer:skip This PR does not need to include a change note backport-3.10 Trigger automatic backporting to the 3.10 release branch by Patchback robot backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot labels Nov 3, 2024
Copy link

codspeed-hq bot commented Nov 3, 2024

CodSpeed Performance Report

Merging #9655 will not alter performance

Comparing yarl_1171 (3bb5d37) with master (8cf9caa)

Summary

✅ 12 untouched benchmarks

@bdraco
Copy link
Member Author

bdraco commented Nov 3, 2024

Screenshot 2024-11-03 at 11 40 01 AM

make_url is faster but it doesn't have much overall impact here

@bdraco bdraco marked this pull request as ready for review November 3, 2024 17:40
@bdraco bdraco enabled auto-merge (squash) November 3, 2024 17:40
Copy link

codecov bot commented Nov 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.64%. Comparing base (8cf9caa) to head (3bb5d37).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9655   +/-   ##
=======================================
  Coverage   98.64%   98.64%           
=======================================
  Files         116      116           
  Lines       35455    35455           
  Branches     4205     4205           
=======================================
  Hits        34976    34976           
  Misses        321      321           
  Partials      158      158           
Flag Coverage Δ
CI-GHA 98.53% <ø> (ø)
OS-Linux 98.20% <ø> (ø)
OS-Windows 96.09% <ø> (ø)
OS-macOS 97.40% <ø> (ø)
Py-3.10.11 97.25% <ø> (ø)
Py-3.10.15 97.68% <ø> (ø)
Py-3.11.10 97.75% <ø> (ø)
Py-3.11.9 97.34% <ø> (+<0.01%) ⬆️
Py-3.12.7 98.23% <ø> (ø)
Py-3.13.0 98.22% <ø> (ø)
Py-3.9.13 97.17% <ø> (+<0.01%) ⬆️
Py-3.9.20 97.60% <ø> (ø)
Py-pypy7.3.16 97.22% <ø> (ø)
VM-macos 97.40% <ø> (ø)
VM-ubuntu 98.20% <ø> (ø)
VM-windows 96.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco merged commit fe8a2ec into master Nov 3, 2024
40 of 41 checks passed
@bdraco bdraco deleted the yarl_1171 branch November 3, 2024 18:01
Copy link
Contributor

patchback bot commented Nov 3, 2024

Backport to 3.10: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply fe8a2ec on top of patchback/backports/3.10/fe8a2ecd1f0c5c514a5ccde96879b78d0fa78c3f/pr-9655

Backporting merged PR #9655 into master

  1. Ensure you have a local repo clone of your fork. Unless you cloned it
    from the upstream, this would be your origin remote.
  2. Make sure you have an upstream repo added as a remote too. In these
    instructions you'll refer to it by the name upstream. If you don't
    have it, here's how you can add it:
    $ git remote add upstream https://github.com/aio-libs/aiohttp.git
  3. Ensure you have the latest copy of upstream and prepare a branch
    that will hold the backported code:
    $ git fetch upstream
    $ git checkout -b patchback/backports/3.10/fe8a2ecd1f0c5c514a5ccde96879b78d0fa78c3f/pr-9655 upstream/3.10
  4. Now, cherry-pick PR Bump yarl to 1.17.1 #9655 contents into that branch:
    $ git cherry-pick -x fe8a2ecd1f0c5c514a5ccde96879b78d0fa78c3f
    If it'll yell at you with something like fatal: Commit fe8a2ecd1f0c5c514a5ccde96879b78d0fa78c3f is a merge but no -m option was given., add -m 1 as follows instead:
    $ git cherry-pick -m1 -x fe8a2ecd1f0c5c514a5ccde96879b78d0fa78c3f
  5. At this point, you'll probably encounter some merge conflicts. You must
    resolve them in to preserve the patch from PR Bump yarl to 1.17.1 #9655 as close to the
    original as possible.
  6. Push this branch to your fork on GitHub:
    $ git push origin patchback/backports/3.10/fe8a2ecd1f0c5c514a5ccde96879b78d0fa78c3f/pr-9655
  7. Create a PR, ensure that the CI is green. If it's not — update it so that
    the tests and any other checks pass. This is it!
    Now relax and wait for the maintainers to process your pull request
    when they have some cycles to do reviews. Don't worry — they'll tell you if
    any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

Copy link
Contributor

patchback bot commented Nov 3, 2024

Backport to 3.11: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.11/fe8a2ecd1f0c5c514a5ccde96879b78d0fa78c3f/pr-9655

Backported as #9656

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Nov 3, 2024
(cherry picked from commit fe8a2ec)
@bdraco bdraco removed the backport-3.10 Trigger automatic backporting to the 3.10 release branch by Patchback robot label Nov 3, 2024
bdraco added a commit that referenced this pull request Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant