Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove noexcept from _restore_ch #1410

Merged
merged 1 commit into from
Nov 9, 2024
Merged

Remove noexcept from _restore_ch #1410

merged 1 commit into from
Nov 9, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Nov 9, 2024

It turns out this can raise ValueError if <Py_UCS4>-1 is out of range

It turns out this can raise ValueError if `<Py_UCS4>-1` is out of range
@bdraco bdraco changed the title Remove noexcept from _restore_ch Remove noexcept from _restore_ch Nov 9, 2024
@bdraco bdraco added the bot:chronographer:skip This PR does not need to include a change note label Nov 9, 2024
@bdraco bdraco enabled auto-merge (squash) November 9, 2024 11:13
Copy link

codspeed-hq bot commented Nov 9, 2024

CodSpeed Performance Report

Merging #1410 will not alter performance

Comparing no_except_restore_ch (3cd5987) with master (dfc41db)

Summary

✅ 83 untouched benchmarks

Copy link

codecov bot commented Nov 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.06%. Comparing base (dfc41db) to head (3cd5987).
Report is 60 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1410   +/-   ##
=======================================
  Coverage   96.06%   96.06%           
=======================================
  Files          31       31           
  Lines        5765     5765           
  Branches      344      344           
=======================================
  Hits         5538     5538           
  Misses        201      201           
  Partials       26       26           
Flag Coverage Δ
CI-GHA 96.06% <100.00%> (ø)
MyPy 48.68% <ø> (ø)
OS-Linux 99.55% <100.00%> (ø)
OS-Windows 99.61% <ø> (ø)
OS-macOS 99.30% <100.00%> (ø)
Py-3.10.11 99.28% <100.00%> (ø)
Py-3.10.15 99.51% <100.00%> (ø)
Py-3.11.10 99.51% <100.00%> (ø)
Py-3.11.9 99.28% <100.00%> (ø)
Py-3.12.7 99.51% <100.00%> (ø)
Py-3.13.0 99.51% <100.00%> (ø)
Py-3.9.13 99.23% <100.00%> (ø)
Py-3.9.20 99.47% <100.00%> (ø)
Py-pypy7.3.16 99.53% <ø> (ø)
Py-pypy7.3.17 99.55% <ø> (ø)
VM-macos-latest 99.30% <100.00%> (ø)
VM-ubuntu-latest 99.55% <100.00%> (ø)
VM-windows-latest 99.61% <ø> (ø)
pytest 99.55% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco merged commit d6a65eb into master Nov 9, 2024
42 of 44 checks passed
@bdraco bdraco deleted the no_except_restore_ch branch November 9, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant