-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add presign_url method, allow more aiohttp versions & py3.12 #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
alvassin
commented
Mar 19, 2024
•
edited
Loading
edited
- Add presign_url method & tests
- Remove 3.7 python support
- Add 3.12 python support & setuptools dev dependency
Pull Request Test Coverage Report for Build 8975944548Details
💛 - Coveralls |
mosquito
approved these changes
Mar 20, 2024
Alviner
approved these changes
Mar 20, 2024
Looks good. Just add some documentation to README. |
alvassin
changed the title
Add presign_url method
Add presign_url method, allow more aiohttp versions
Apr 30, 2024
alvassin
changed the title
Add presign_url method, allow more aiohttp versions
Add presign_url method, allow more aiohttp versions & py3.12
Apr 30, 2024
Alviner
approved these changes
May 1, 2024
mosquito
approved these changes
May 1, 2024
leenr
approved these changes
May 2, 2024
dizballanze
reviewed
May 2, 2024
alvassin
force-pushed
the
master
branch
2 times, most recently
from
May 6, 2024 20:38
3255f23
to
12ca599
Compare
mosquito
approved these changes
May 6, 2024
mosquito
approved these changes
May 6, 2024
alvassin
force-pushed
the
master
branch
2 times, most recently
from
May 6, 2024 21:13
fecbd83
to
73e3837
Compare
leenr
approved these changes
May 7, 2024
dizballanze
approved these changes
May 7, 2024
Alviner
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.