support common_prefixes response object parsing.

[toppk]

resolves #30

[coveralls]

Pull Request Test Coverage Report for Build 8511952455

Details

• 4 of 7 (57.14%) changed or added relevant lines in 2 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.02%) to 90.504%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
aiohttp_s3_client/client.py	2	5	40.0%

Totals
Change from base Build 7486418958:	0.02%
Covered Lines:	467
Relevant Lines:	516

---

💛 - Coveralls

[toppk]

i figured out how to run tests (there should be developer docs):

podman run -p 9090:9090 --env initialBuckets=test   docker://adobe/s3mock
S3_URL=http://user:hackme@localhost:9090/test/ poetry run pytest -vv tests

but there is an issue:
if you run:

$ curl 'http://user:hackme@localhost:9090/test/?list-type=2&prefix=test/&delimiter=/&encoding-type=url'
<ListBucketResult><Name>test</Name><Prefix>test/</Prefix><MaxKeys>1000</MaxKeys><IsTruncated>false</IsTruncated><KeyCount>0</KeyCount><EncodingType>url</EncodingType></ListBucketResult>You have new mail in /var/spool/mail/toppk

you see there isn't the xml header with the namespace.

the list objects tests are false negative because there is no response. if you added a bogus assert 1==2 test inside the with block you will see that.

a fix is to set the NS = "" (in parse_list_objects, if you do it a the module level in xml.py, it will break other things).

obviously this is an issue in my s3mock, but given there's a potential for false negative in the way the tests are structured, it may be an issue on your side as well. I've tried to look at s3mock to see if I can figure out what's happening there but nothing so far.

[toppk]

i've tested a bunch of older version of s3mock, and same issues.

for references this is what aws s3 gives, which is why this code works in prod (for me).

<?xml version="1.0" encoding="UTF-8"?>
<ListBucketResult xmlns="http://s3.amazonaws.com/doc/2006-03-01/">
...
</ListBucketResult>

[mosquito]

@toppk may be s3mock doesn’t support that features? Could you please test it again with minio?

[toppk]

minio behaves properly.

$ curl http://MY-MINIO-SERVER/test
<?xml version="1.0" encoding="UTF-8"?>
<ListBucketResult xmlns="http://s3.amazonaws.com/doc/2006-03-01/"><Name>test</Name><Prefix></Prefix><Marker></Marker><MaxKeys>1000</MaxKeys><IsTruncated>false</IsTruncated></ListBucketResult>

I'm not sure if there's some sort of enviriomental/pebcak issue, but I've created an issue on s3mock to see if they can help me out.

adobe/S3Mock#1754