Fix the issue when internal CPU miner update the block template

aionnetwork · Dec 9, 2020 · 5c5a608 · 5c5a608
1 parent 5a4f8da
commit 5c5a608
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 25 deletions.
diff --git a/modAionImpl/src/org/aion/zero/impl/pow/AionPoW.java b/modAionImpl/src/org/aion/zero/impl/pow/AionPoW.java
@@ -128,7 +128,9 @@ public void init(IAionBlockchain blockchain, IPendingState pendingState, IEventM
                                                 || now - lastUpdate.get() > 10000) {
                                             createNewBlockTemplate();
                                         } else {
-                                            updateTimestamp(TimeUnit.MILLISECONDS.toSeconds(now));
+                                            if (TimeUnit.MILLISECONDS.toSeconds(now) == latestBlockTemplate.getTimestamp() + 1) {
+                                                createNewBlockTemplate();
+                                            }
                                         }
                                     } catch (InterruptedException e) {
                                         break;
@@ -277,20 +279,6 @@ private synchronized void createNewBlockTemplate() {
         }
     }
 
-    /** Creates a new block template. */
-    private synchronized void updateTimestamp(long systemTime) {
-        if (!shutDown.get() && systemTime > latestBlockTemplate.getTimestamp()) {
-            MiningBlockHeader newHeader = latestBlockTemplate.getHeader().updateTimestamp(systemTime);
-            MiningBlock newBlock = new MiningBlock(newHeader, latestBlockTemplate.getTransactionsList());
-
-            EventConsensus ev = new EventConsensus(EventConsensus.CALLBACK.ON_BLOCK_TEMPLATE);
-            ev.setFuncArgs(Collections.singletonList(newBlock));
-            eventMgr.newEvent(ev);
-
-            latestBlockTemplate = newBlock;
-        }
-    }
-
     public synchronized void shutdown() {
         if (ees != null) {
             ees.shutdown();

diff --git a/modAionImpl/src/org/aion/zero/impl/types/MiningBlockHeader.java b/modAionImpl/src/org/aion/zero/impl/types/MiningBlockHeader.java
@@ -135,16 +135,6 @@ public MiningBlockHeader(MiningBlockHeader.Builder builder) {
         this.solution = builder.solution;
         this.nonce = builder.nonce;
     }
-
-    /**
-     * Returns a new header that is identical to this one, except with a different timestamp
-     */    
-    public MiningBlockHeader updateTimestamp(long newTimestamp) {
-        return Builder.newInstance()
-                .withHeader(this)
-                .withTimestamp(newTimestamp)
-                .build();
-    }
 
     public byte[] getSolution() {
         return solution.clone();