Handle move cursor in visual mode correctly.

aioutecism · Apr 6, 2017 · 5ee0113 · 5ee0113
1 parent 650bb6d
commit 5ee0113
Showing 1 changed file with 17 additions and 19 deletions.
diff --git a/src/Actions/MoveCursor.ts b/src/Actions/MoveCursor.ts
@@ -2,6 +2,7 @@ import {window, Position, Selection} from 'vscode';
 import {ActionReveal} from './Reveal';
 import {Motion} from '../Motions/Motion';
 import {UtilPosition} from '../Utils/Position';
+import {UtilSelection} from '../Utils/Selection';
 
 export class ActionMoveCursor {
 
@@ -66,34 +67,31 @@ export class ActionMoveCursor {
         activeTextEditor.selections = activeTextEditor.selections.map((selection, i) => {
             let anchor: Position;
 
-            let active = args.motions.reduce((position, motion) => {
-                return motion.apply(position, {
-                    isInclusive: args.isVisualMode,
-                    preferedColumn: ActionMoveCursor.preferedColumnBySelectionIndex[i]
-                });
-            }, selection.active);
+            let active = args.motions.reduce(
+                (position, motion) => {
+                    return motion.apply(position, {
+                        preferedColumn: ActionMoveCursor.preferedColumnBySelectionIndex[i]
+                    });
+                },
+                args.isVisualMode
+                    ? UtilSelection.getActiveInVisualMode(selection)
+                    : selection.active
+            );
 
             if (args.isVisualMode) {
                 anchor = selection.anchor;
 
-                if (anchor.isEqual(active)) {
-                    if (active.isBefore(selection.active)) {
-                        anchor = anchor.translate(0, +1);
-                        if (active.character > 0) {
-                            active = active.translate(0, -1);
-                        }
-                    }
-                    else {
-                        if (anchor.character > 0) {
-                            anchor = anchor.translate(0, -1);
-                        }
+                if (active.isAfterOrEqual(anchor)) {
+                    const lineLength = activeTextEditor.document.lineAt(active.line).text.length;
+                    if (active.character < lineLength) {
                         active = active.translate(0, +1);
                     }
                 }
-                else if (active.isAfter(anchor) && selection.active.isBefore(selection.anchor)) {
+
+                if (active.isAfter(anchor) && selection.isReversed) {
                     anchor = anchor.translate(0, -1);
                 }
-                else if (active.isBefore(anchor) && selection.active.isAfter(selection.anchor)) {
+                else if (active.isBefore(anchor) && !selection.isReversed) {
                     anchor = anchor.translate(0, +1);
                 }
             }