Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a github action to test on push #268

Merged
merged 7 commits into from
Jun 7, 2020

Conversation

alisonatwork
Copy link
Collaborator

@alisonatwork alisonatwork commented May 20, 2020

This PR introduces Github actions as CI so that we can get a full lint and test run for PRs and on master.

Some of the tests were a little flakey, so there are some small changes here:

  1. Bring back the retries argument for the tests
  2. Upgrade Mocha, since retries actually didn't work properly until 7.1.0
  3. Use " instead of ' so that Prettier will run on Windows
  4. Change the , and ; tests so that they don't reach into the extension to clear the last motion, just do a non-matching f first

The fourth one is necessary because when you run all of the test together, motions from previous tests will affect the outcome of those two tests. The previous behavior which did a reach around into ../../src doesn't work any more because with Webpack (#270) the actual running source has moved elsewhere.

I guess we could export the clear motion command as part of extension public API, but I think it would be nicer if the BlackBox tests didn't have to reach into the extension so much. There is another solution for this, and it is similar to something I am playing with in #258: we need to flag certain tests as requiring a "clean" document, and then those tests should get their own fresh tab. I think that is out of scope for this PR, though.

@alisonatwork alisonatwork force-pushed the github-actions branch 2 times, most recently from 1fbdfb7 to 8998bc6 Compare May 20, 2020 16:24
@alisonatwork alisonatwork force-pushed the github-actions branch 4 times, most recently from 99072e8 to c6f46e6 Compare June 7, 2020 09:59
@alisonatwork alisonatwork force-pushed the github-actions branch 4 times, most recently from bd447aa to e2a8eec Compare June 7, 2020 12:11
@alisonatwork alisonatwork marked this pull request as ready for review June 7, 2020 12:32
@alisonatwork alisonatwork merged commit a9c0e22 into aioutecism:master Jun 7, 2020
@alisonatwork
Copy link
Collaborator Author

Heads up: I merged this PR directly, because while it was on a fork the build would not be triggered anyway.

Here is the successful build on master: https://github.com/aioutecism/amVim-for-VSCode/actions/runs/127643761

Cc @aioutecism @jackfranklin @karlhorky and @tejanium for visibility.

@alisonatwork
Copy link
Collaborator Author

I was hoping after the merge to master, it would show up the build status of forks inside the PR, but I just rebase/force-pushed my branch over in #258 and no luck. I will look into this a bit more later. At least developers can check if the build worked in their own fork now.

@alisonatwork alisonatwork deleted the github-actions branch March 21, 2021 23:02
@alisonatwork alisonatwork restored the github-actions branch March 21, 2021 23:02
@alisonatwork alisonatwork deleted the github-actions branch March 21, 2021 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant