-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add a github action to test on push #268
Conversation
1fbdfb7
to
8998bc6
Compare
99072e8
to
c6f46e6
Compare
bd447aa
to
e2a8eec
Compare
e2a8eec
to
3444d61
Compare
3444d61
to
de10d0d
Compare
Heads up: I merged this PR directly, because while it was on a fork the build would not be triggered anyway. Here is the successful build on master: https://github.com/aioutecism/amVim-for-VSCode/actions/runs/127643761 Cc @aioutecism @jackfranklin @karlhorky and @tejanium for visibility. |
I was hoping after the merge to master, it would show up the build status of forks inside the PR, but I just rebase/force-pushed my branch over in #258 and no luck. I will look into this a bit more later. At least developers can check if the build worked in their own fork now. |
This PR introduces Github actions as CI so that we can get a full lint and test run for PRs and on master.
Some of the tests were a little flakey, so there are some small changes here:
retries
argument for the testsretries
actually didn't work properly until 7.1.0"
instead of'
so that Prettier will run on Windows,
and;
tests so that they don't reach into the extension to clear the last motion, just do a non-matchingf
firstThe fourth one is necessary because when you run all of the test together, motions from previous tests will affect the outcome of those two tests. The previous behavior which did a reach around into
../../src
doesn't work any more because with Webpack (#270) the actual running source has moved elsewhere.I guess we could export the clear motion command as part of extension public API, but I think it would be nicer if the BlackBox tests didn't have to reach into the extension so much. There is another solution for this, and it is similar to something I am playing with in #258: we need to flag certain tests as requiring a "clean" document, and then those tests should get their own fresh tab. I think that is out of scope for this PR, though.