-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added New LLM Cohere #81
Conversation
madhavi-peddireddy
commented
Oct 25, 2024
Removed |
Please add the model name inside llms init.py file |
src/beyondllm/llms/cohere.py
Outdated
from typing import Any, Dict | ||
from dataclasses import dataclass, field | ||
import os | ||
import cohere |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
import the cohere module inside load_llm
refer to other LLMs. This needs to be under exception block
src/beyondllm/llms/together_ai.py
Outdated
from typing import Any, Dict | ||
from dataclasses import dataclass, field | ||
import os | ||
from together import Together |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
import the together module inside load_llm
refer to other LLMs. This needs to be under exception block
src/beyondllm/llms/together_ai.py
Outdated
def predict(self, prompt: Any) -> str: | ||
"""Generate a response from the model based on the provided prompt.""" | ||
try: | ||
stream = self.client.chat.completions.create( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
by default, its ideal to keep stream as False. please change it as per cohere implementation you have done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@madhavi-peddireddy
Congrats on being approved for the Hacktoberfest swags! Please share your details with me so we can send it over to you.
You can either drop the details in our Discord channel: bit.ly/aiplanet-discord or email me at [email protected].
@CodiumAI-Agent /review |
PR Reviewer Guide 🔍(Review updated until commit 89c8062)Here are some key observations to aid the review process:
|
@CodiumAI-Agent /review |
Persistent review updated to latest commit 89c8062 |