Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools deprecation and new format support #89

Merged
merged 7 commits into from
Nov 7, 2024
Merged

Conversation

tarun-aiplanet
Copy link
Member

No description provided.

@tarun-aiplanet tarun-aiplanet mentioned this pull request Oct 31, 2024
4 tasks
from typing import ClassVar, Dict, Any

try:
import arxiv
Copy link
Contributor

@gourab-aiplanet gourab-aiplanet Oct 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we use this tool will it work or explicitly we will have to run the install command? @tarun-aiplanet

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we will have to run install command


class ExaSearch(BaseAction):
class ConfigurableAction(BaseAction):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tarun-aiplanet why are we redefining the ConfigurableAction class?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need this for configuring the api keys and other user defined params right?

except ImportError:
raise OpenAGIException("Install googlesearch-python with cmd `pip install googlesearch-python`")

class ConfigurableAction(BaseAction):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Define it separately and use import in all the places. @tarun-aiplanet

@tarun-aiplanet tarun-aiplanet merged commit ad65789 into main Nov 7, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants