Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverts #341 and instead adds that information in the README #354

Merged
merged 2 commits into from
Sep 19, 2023
Merged

Reverts #341 and instead adds that information in the README #354

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d3d4d31
Revert proguard rule
vinaygaba Sep 19, 2023
fa37d4c
Update README with information about proguard
vinaygaba Sep 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,14 @@ class MyRootModule: ShowkaseRootModule
startActivity(Showkase.getBrowserIntent(context))
```

Most users of Showkase will use it in their debug builds. However, if you have a use case where you would
like to use Showkase in a release build (or a build that has minification enabled), you will need to add
the following line to your proguard rules

```
-keep public class * extends com.airbnb.android.showkase.models.ShowkaseProvider
```

## Documentation

##### 1. @ShowkaseComposable
Expand Down
2 changes: 1 addition & 1 deletion showkase/consumer-rules.pro
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
-keep public class * extends com.airbnb.android.showkase.models.ShowkaseProvider

Loading