Skip to content

Conversation

@JKHiggins
Copy link
Contributor

No description provided.

@JKHiggins
Copy link
Contributor Author

@jimmyngo I've rebased this on master and it's passing the build now.

@jimmyngo
Copy link
Collaborator

This is pretty straight forward, but what's the value of passing secrets through ENV versus putting it in the directly in the config?

@JKHiggins
Copy link
Contributor Author

We don't encrypt our config file, so it would be insecure to commit them to the repo. We prefer using ENV for this, the secrets can still be put in the ENV directly if that's what you want to do, but this just enables you to be more secure with your secrets.

@jimmyngo
Copy link
Collaborator

There's a few new classes of errors that can occur when calling ERB.new with invalid syntax/usage. We should handle them all, or change the error handling to something more generic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants