Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

increase peerDep/devDep range for react and bump enzyme #2

Merged
merged 5 commits into from
Oct 12, 2017
Merged

increase peerDep/devDep range for react and bump enzyme #2

merged 5 commits into from
Oct 12, 2017

Conversation

brucewpaul
Copy link
Contributor

This pr updates react and related packages so that react16 is
supported. Enzyme and related packages are also bumped to support
react16. We also configure enzyme to work with whichever react is
currently installed.

@brucewpaul
increase peerDep/devDep range for react and bump enzyme
2bd8220 
This pr updates react and related packages so that react16 is
supported. Enzyme and related packages are also bumped to support
react16. We also configure enzyme to work with whichever react is
currently installed.
@brucewpaul
Copy link
Contributor Author

this pr addresses #1

@brucewpaul
Copy link
Contributor Author

@ljharb it seems like the extraneous packages are throwing an error. I remember you saying that they weren't supposed to. Thoughts?

@ljharb
Copy link
Collaborator

ljharb commented Oct 10, 2017

@brucewpaul https://github.com/airbnb/react-with-direction/blob/master/.travis.yml#L7 runs npm ls; are you sure that the only issue is extraneous packages?

@brucewpaul
Copy link
Contributor Author

brucewpaul commented Oct 11, 2017 •
edited
Loading

@ljharb there was a typo in the react:16 script, but other then that, I ran rm -rf node_modules && npm install && sh install-relevant-react.sh (with manually changing the default react version) and they all install fine, pass tests, but when I npm ls, I get the npm ERR! extraneous error

@ljharb
Copy link
Collaborator

ljharb commented Oct 11, 2017

I guess temporarily let's comment out the npm ls command in travis.yml; we can restore it after we build a better solution for multi-react/enzyme testing (let's talk more about that this week)

@brucewpaul
remove npm ls from travis.yml
603dac4 
we should work on a better solution to deal with supporting
multiple react versions and enzyme adapters for each
@ljharb ljharb merged commit a40775e into airbnb:master Oct 12, 2017
ljharb added a commit that referenced this pull request Nov 17, 2017
@ljharb
Release v1.1.0
e8e8962 
  - [New] increase peerDep/devDep range for react and bump enzyme (#2)
  - [Deps] update `hoist-non-react-statics`, `prop-types`
  - [Dev Deps] update `babel-jest`, `chai`, `eslint`, `eslint-config-airbnb`, `eslint-plugin-jsx-a11y`, `eslint-plugin-react`, `jest`, `rimraf`, `sinon`, `sinon-chai`, `webpack`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brucewpaul @ljharb