Match call-site paren on multi-line function calls #308
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates our Swift formatting rules to enable
callsiteparen = balanced
, which ensures consistent placement of parentheses and arguments in multiline function calls. With this option, the opening and closing parentheses are always balanced across lines, improving readability and making edits and diffs more predictable. It also works seamlessly with trailing commas to simplify future changes.Reasoning
Currently, multiline function calls can inconsistently close the parenthesis on the same line as the last argument:
With
callsiteparen = balanced
, this becomes:Benefits
The closing parenthesis always appears vertically aligned with the opening parenthesis, reducing visual clutter and ambiguity - particularly with SwiftUI chains.
Before -
setBehaviors
is aligned with the arguments.After -
setBehaviors
is aligned with what it is modifying.Trailing commas make adding or removing parameters much cleaner and reduce diff noise:
Adding another argument:
onFailure: { ... }, + completion: { ... }, )
Removing an argument:
- onFailure: { ... }, )
Easier visual diffing
The uniform style prevents mismatched or ambiguous closings, which is especially useful in large nested calls.
Community alignment
This approach is common in modern Swift style guides and is fully supported by
swift-format
andswiftlint
.Conclusion
Enabling
callsiteparen = balanced
gives us consistent, clear multiline call formatting that reduces code review noise and makes refactoring safer.