Skip to content

fix(concurrent-partition-cursor): update cursor comparison to leverage ab_datetime #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

fix(concurrent-partition-cursor): update cursor comparison to leverage ab_datetime #297

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ef0449a
update comparison to parse to ab datetime
pnilan Jan 30, 2025
96e8b0c
chore: format code
pnilan Jan 30, 2025
7c7a340
Merge branch 'main' into pnilan/concurrent-partition-cursor/integrate…
aaronsteers Jan 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions airbyte_cdk/sources/declarative/incremental/concurrent_partition_cursor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
AbstractStreamStateConverter,
)
from airbyte_cdk.sources.types import Record, StreamSlice, StreamState
from airbyte_cdk.utils.datetime_helpers import AirbyteDateTime, ab_datetime_parse

logger = logging.getLogger("airbyte")

Expand Down Expand Up @@ -151,8 +152,12 @@ def close_partition(self, partition: Partition) -> None:
):
if (
self._new_global_cursor is None
or self._new_global_cursor[self.cursor_field.cursor_field_key]
< cursor.state[self.cursor_field.cursor_field_key]
or ab_datetime_parse(
self._new_global_cursor[self.cursor_field.cursor_field_key]
).to_epoch_millis()
< ab_datetime_parse(
cursor.state[self.cursor_field.cursor_field_key]
).to_epoch_millis()
):
self._new_global_cursor = copy.deepcopy(cursor.state)
if not self._use_global_cursor:
Expand Down
Loading