Skip to content

fix: substreampartitionrouter state migration from child when it is empty #444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 25, 2025
Merged

fix: substreampartitionrouter state migration from child when it is empty #444

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af400e5
fix substreampartitionrouter state migration from child when it is empty
maxi297 Mar 25, 2025
26095cb
Auto-fix lint and format issues
Mar 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion airbyte_cdk/sources/declarative/partition_routers/substream_partition_router.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,7 +374,11 @@ def _migrate_child_state_to_parent_state(self, stream_state: StreamState) -> Str
# Ignore per-partition states or invalid formats.
if isinstance(substream_state, (list, dict)) or len(substream_state_values) != 1:
# If a global state is present under the key "state", use its first value.
if "state" in stream_state and isinstance(stream_state["state"], dict):
if (
"state" in stream_state
and isinstance(stream_state["state"], dict)
and stream_state["state"] != {}
):
substream_state = list(stream_state["state"].values())[0]
else:
return {}
Expand Down
12 changes: 12 additions & 0 deletions unit_tests/sources/declarative/partition_routers/test_substream_partition_router.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -473,6 +473,17 @@ def test_substream_partition_router_invalid_parent_record_type():
},
{"parent_stream_cursor": "2023-05-27T00:00:00Z"},
),
# Case 7: Migrate child state to parent state but child state is empty
(
{
"state": {},
"states": [],
"parent_state": {"posts": {}},
"lookback_window": 1,
"use_global_cursor": False,
},
{},
),
],
ids=[
"empty_initial_state",
Expand All @@ -481,6 +492,7 @@ def test_substream_partition_router_invalid_parent_record_type():
"initial_state_no_parent_per_partition_state",
"initial_state_with_parent_state",
"initial_state_no_parent_global_state_declarative",
"initial_state_no_parent_and_no_child",
],
)
def test_set_initial_state(initial_state, expected_parent_state):
Expand Down
Loading