Skip to content

Commit

Permalink
fix tests
Browse files Browse the repository at this point in the history
  • Loading branch information
alafanechere committed Sep 18, 2023
1 parent b2ca7ac commit 0a1d09c
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 31 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
from typing import TYPE_CHECKING, Callable, List, Optional

import toml
from dagger import CacheSharingMode, CacheVolume, Client, Container, DaggerError, Directory, File, Platform, Secret
from dagger import CacheVolume, Client, Container, DaggerError, Directory, File, Platform, Secret
from dagger.engine._version import CLI_VERSION as dagger_engine_version
from pipelines import consts
from pipelines.consts import (
Expand Down Expand Up @@ -365,36 +365,6 @@ def with_python_connector_source(context: ConnectorContext) -> Container:
return with_python_package(context, testing_environment, connector_source_path)


async def with_python_connector_installed(context: ConnectorContext) -> Container:
"""Install an airbyte connector python package in a testing environment.
Args:
context (ConnectorContext): The current test context, providing the repository directory from which the connector sources will be pulled.
Returns:
Container: A python environment container (with the connector installed).
"""
connector_source_path = str(context.connector.code_directory)
testing_environment: Container = with_testing_dependencies(context)
exclude = [
f"{context.connector.code_directory}/{item}"
for item in [
"secrets",
"metadata.yaml",
"bootstrap.md",
"icon.svg",
"README.md",
"Dockerfile",
"acceptance-test-docker.sh",
"build.gradle",
".hypothesis",
".dockerignore",
]
]
return await with_installed_python_package(
context, testing_environment, connector_source_path, additional_dependency_groups=["dev", "tests", "main"], exclude=exclude
)


async def with_ci_credentials(context: PipelineContext, gsm_secret: Secret) -> Container:
"""Install the ci_credentials package in a python environment.
Expand Down
1 change: 1 addition & 0 deletions airbyte-ci/connectors/pipelines/pipelines/tests/common.py
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,7 @@ class AcceptanceTests(Step):
title = "Acceptance tests"
CONTAINER_TEST_INPUT_DIRECTORY = "/test_input"
CONTAINER_SECRETS_DIRECTORY = "/test_input/secrets"
skipped_exit_code = 5

@property
def base_cat_command(self) -> List[str]:
Expand Down

0 comments on commit 0a1d09c

Please sign in to comment.