Skip to content

Commit

Permalink
update
Browse files Browse the repository at this point in the history
  • Loading branch information
girarda committed Oct 11, 2023
1 parent 2d1dda0 commit 0ca3ede
Showing 1 changed file with 3 additions and 6 deletions.
9 changes: 3 additions & 6 deletions airbyte-ci/connectors/pipelines/pipelines/contexts.py
Original file line number Diff line number Diff line change
Expand Up @@ -333,9 +333,9 @@ def __init__(
fail_fast: bool = False,
fast_tests_only: bool = False,
code_tests_only: bool = False,
use_local_cdk: bool = False,
use_host_gradle_dist_tar: bool = False,
open_report_in_browser: bool = True,
use_local_cdk: bool = False,
):
"""Initialize a connector context.
Expand All @@ -359,7 +359,6 @@ def __init__(
code_tests_only (bool, optional): Whether to ignore non-code tests like QA and metadata checks. Defaults to False.
use_host_gradle_dist_tar (bool, optional): Used when developing java connectors with gradle. Defaults to False.
open_report_in_browser (bool, optional): Open HTML report in browser window. Defaults to True.
use_local_cdk (bool, optional): Whether to use the local CDK. Defaults to False.
"""

self.pipeline_name = pipeline_name
Expand All @@ -374,9 +373,9 @@ def __init__(
self.fail_fast = fail_fast
self.fast_tests_only = fast_tests_only
self.code_tests_only = code_tests_only
self.use_local_cdk = use_local_cdk
self.use_host_gradle_dist_tar = use_host_gradle_dist_tar
self.open_report_in_browser = open_report_in_browser
self.use_local_cdk = use_local_cdk

super().__init__(
pipeline_name=pipeline_name,
Expand All @@ -394,6 +393,7 @@ def __init__(
ci_gcs_credentials=ci_gcs_credentials,
ci_git_user=ci_git_user,
ci_github_access_token=ci_github_access_token,
use_local_cdk=use_local_cdk,
)

@property
Expand Down Expand Up @@ -546,9 +546,6 @@ def __init__(
pipeline_name = f"Publish {connector.technical_name}"
pipeline_name = pipeline_name + " (pre-release)" if pre_release else pipeline_name

if use_local_cdk and not pre_release:
raise ValueError("Cannot use local CDK for non-pre-release connector")

super().__init__(
pipeline_name=pipeline_name,
connector=connector,
Expand Down

0 comments on commit 0ca3ede

Please sign in to comment.