Skip to content

Commit

Permalink
update disablings
Browse files Browse the repository at this point in the history
  • Loading branch information
edgao committed Dec 17, 2024
1 parent 8f3afd0 commit 28cfe8a
Showing 1 changed file with 8 additions and 31 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -40,17 +40,7 @@ abstract class IcebergV2WriteTest(
nullEqualsUnset = true,
) {
@Test
@Disabled(
"Expected because we seem to be mapping timestamps to long when we should be mapping them to an OffsetDateTime"
)
override fun testBasicTypes() {
super.testBasicTypes()
}

@Test
@Disabled(
"Expected because we seem to be mapping timestamps to long when we should be mapping them to an OffsetDateTime"
)
@Disabled("This is currently hanging forever and we should look into why")
override fun testInterruptedTruncateWithPriorData() {
super.testInterruptedTruncateWithPriorData()
}
Expand All @@ -62,29 +52,21 @@ abstract class IcebergV2WriteTest(
}

@Test
// @Disabled
override fun testContainerTypes() {
super.testContainerTypes()
}

@Test
@Disabled(
"Expected because we seem to be mapping timestamps to long when we should be mapping them to an OffsetDateTime"
)
@Disabled("This is currently hanging forever and we should look into why")
override fun resumeAfterCancelledTruncate() {
super.resumeAfterCancelledTruncate()
}

@Test
@Disabled("This is expected")
override fun testAppendSchemaEvolution() {
super.testAppendSchemaEvolution()
// @Disabled
override fun testContainerTypes() {
super.testContainerTypes()
}

@Test
// @Disabled
override fun testUnions() {
super.testUnions()
@Disabled("This is expected (dest-iceberg-v2 doesn't yet support schema evolution)")
override fun testAppendSchemaEvolution() {
super.testAppendSchemaEvolution()
}
}

Expand All @@ -101,11 +83,6 @@ class IcebergGlueWriteTest :
override fun testContainerTypes() {
super.testContainerTypes()
}

@Test
override fun testUnions() {
super.testUnions()
}
}

@Disabled(
Expand Down

0 comments on commit 28cfe8a

Please sign in to comment.