fix redshift sqlgenerator

airbytehq · Jan 3, 2024 · 3c53c37 · 3c53c37
1 parent 4d045ca
commit 3c53c37
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/...va/io/airbyte/integrations/destination/redshift/typing_deduping/RedshiftSqlGenerator.java b/...va/io/airbyte/integrations/destination/redshift/typing_deduping/RedshiftSqlGenerator.java
@@ -135,7 +135,7 @@ protected Field<?> castedField(final Field<?> field, final AirbyteType type, fin
   }
 
   @Override
-  protected List<Field<?>> extractRawDataFields(LinkedHashMap<ColumnId, AirbyteType> columns) {
+  protected List<Field<?>> extractRawDataFields(final LinkedHashMap<ColumnId, AirbyteType> columns, final boolean useExpensiveSaferCasting) {
     return columns
         .entrySet()
         .stream()
@@ -157,7 +157,7 @@ private Field<String> jsonSerialize(final Field<?> field) {
    * @param arrays
    * @return
    */
-  Field<?> arrayConcatStmt(List<Field<?>> arrays) {
+  Field<?> arrayConcatStmt(final List<Field<?>> arrays) {
     if (arrays.isEmpty()) {
       return field("ARRAY()"); // Return an empty string if the list is empty
     }
@@ -168,8 +168,8 @@ Field<?> arrayConcatStmt(List<Field<?>> arrays) {
     }
 
     // Recursive case: construct ARRAY_CONCAT function call
-    Field<?> lastValue = arrays.get(arrays.size() - 1);
-    Field<?> recursiveCall = arrayConcatStmt(arrays.subList(0, arrays.size() - 1));
+    final Field<?> lastValue = arrays.get(arrays.size() - 1);
+    final Field<?> recursiveCall = arrayConcatStmt(arrays.subList(0, arrays.size() - 1));
 
     return function("ARRAY_CONCAT", getSuperType(), recursiveCall, lastValue);
   }
@@ -227,7 +227,7 @@ public boolean existingSchemaMatchesStreamConfig(final StreamConfig stream, fina
    * @return
    */
   @Override
-  protected Field<Integer> getRowNumber(List<ColumnId> primaryKeys, Optional<ColumnId> cursor) {
+  protected Field<Integer> getRowNumber(final List<ColumnId> primaryKeys, final Optional<ColumnId> cursor) {
     final List<Field<?>> primaryKeyFields =
         primaryKeys != null ? primaryKeys.stream().map(columnId -> field(quotedName(columnId.name()))).collect(Collectors.toList())
             : new ArrayList<>();
@@ -255,7 +255,7 @@ protected Field<Timestamp> currentTimestamp() {
   }
 
   @Override
-  public boolean shouldRetry(Exception e) {
+  public boolean shouldRetry(final Exception e) {
     return false;
   }