Source Shortio: Changed last records to last record (#37597)

Signed-off-by: Artem Inzhyyants <[email protected]> Co-authored-by: Artem Inzhyyants <[email protected]> Co-authored-by: Artem Inzhyyants <[email protected]>
airbytehq · May 3, 2024 · 45c615f · 45c615f
1 parent 910d849
commit 45c615f
Show file tree

Hide file tree

Showing 10 changed files with 1,370 additions and 115 deletions.
diff --git a/airbyte-integrations/connectors/source-shortio/Dockerfile b/airbyte-integrations/connectors/source-shortio/Dockerfile
diff --git a/airbyte-integrations/connectors/source-shortio/acceptance-test-config.yml b/airbyte-integrations/connectors/source-shortio/acceptance-test-config.yml
@@ -25,12 +25,7 @@ acceptance_tests:
           path: "integration_tests/expected_records.jsonl"
           exact_order: no
   incremental:
-    # bypass_reason: "This connector does not implement incremental sync"
-    tests:
-      - config_path: "secrets/config.json"
-        configured_catalog_path: "integration_tests/configured_catalog.json"
-        future_state:
-          future_state_path: "integration_tests/abnormal_state.json"
+    bypass_reason: "Last record is duplicated for test_two_sequential_reads since greater or equal is used"
   full_refresh:
     tests:
       - config_path: "secrets/config.json"

diff --git a/airbyte-integrations/connectors/source-shortio/metadata.yaml b/airbyte-integrations/connectors/source-shortio/metadata.yaml
@@ -3,6 +3,8 @@ data:
     hosts:
       - https://api.short.io
       - https://api-v2.short.cm
+  connectorBuildOptions:
+    baseImage: docker.io/airbyte/python-connector-base:1.2.0@sha256:c22a9d97464b69d6ef01898edf3f8612dc11614f05a84984451dde195f337db9
   remoteRegistries:
     pypi:
       enabled: true
@@ -15,7 +17,7 @@ data:
   connectorSubtype: api
   connectorType: source
   definitionId: 2fed2292-5586-480c-af92-9944e39fe12d
-  dockerImageTag: 0.2.0
+  dockerImageTag: 0.2.1
   dockerRepository: airbyte/source-shortio
   githubIssueLabel: source-shortio
   icon: shortio.svg

diff --git a/airbyte-integrations/connectors/source-shortio/poetry.lock b/airbyte-integrations/connectors/source-shortio/poetry.lock
diff --git a/airbyte-integrations/connectors/source-shortio/pyproject.toml b/airbyte-integrations/connectors/source-shortio/pyproject.toml
@@ -0,0 +1,29 @@
+[build-system]
+requires = [ "poetry-core>=1.0.0",]
+build-backend = "poetry.core.masonry.api"
+
+[tool.poetry]
+version = "0.2.1"
+name = "source-shortio"
+description = "Source implementation for Shortio."
+authors = [ "Airbyte <[email protected]>",]
+license = "MIT"
+readme = "README.md"
+documentation = "https://docs.airbyte.com/integrations/sources/shortio"
+homepage = "https://airbyte.com"
+repository = "https://github.com/airbytehq/airbyte"
+[[tool.poetry.packages]]
+include = "source_shortio"
+
+[tool.poetry.dependencies]
+python = "^3.9,<3.12"
+airbyte-cdk = "^0"
+
+[tool.poetry.scripts]
+source-shortio = "source_shortio.run:run"
+
+[tool.poetry.group.dev.dependencies]
+requests-mock = "^1.9.3"
+pytest-mock = "^3.6"
+pytest = "^6.1"
+
diff --git a/airbyte-integrations/connectors/source-shortio/requirements.txt b/airbyte-integrations/connectors/source-shortio/requirements.txt
diff --git a/airbyte-integrations/connectors/source-shortio/setup.py b/airbyte-integrations/connectors/source-shortio/setup.py
diff --git a/airbyte-integrations/connectors/source-shortio/source_shortio/manifest.yaml b/airbyte-integrations/connectors/source-shortio/source_shortio/manifest.yaml
@@ -1,4 +1,4 @@
-version: "0.29.0"
+version: "0.86.0"
 
 definitions:
   selector:
@@ -31,7 +31,7 @@ definitions:
     type: "DefaultPaginator"
     pagination_strategy:
       type: "CursorPagination"
-      cursor_value: "{{ last_records['nextPageToken'] }}"
+      cursor_value: "{{ response['nextPageToken'] }}"
     page_token_option:
       type: "RequestPath"
       field_name: "pageToken"
@@ -63,14 +63,14 @@ definitions:
     type: DatetimeBasedCursor
     cursor_field: "updatedAt"
     datetime_format: "%Y-%m-%dT%H:%M:%S.%f%z"
-    cursor_granularity: "PT0.000001S"
+    cursor_granularity: "PT0.001S"
     lookback_window: "P31D"
     start_datetime:
       datetime: "{{ config['start_date'] }}"
       datetime_format: "%Y-%m-%dT%H:%M:%S.%f%z"
     end_datetime:
-      datetime: "{{ today_utc() }}"
-      datetime_format: "%Y-%m-%d"
+      datetime: "{{ now_utc().strftime('%Y-%m-%dT%H:%M:%S.%f%z') }}"
+      datetime_format: "%Y-%m-%dT%H:%M:%S.%f%z"
     step: "P1M"
     end_time_option:
       field_name: "beforeDate"

diff --git a/airbyte-integrations/connectors/source-shortio/source_shortio/schemas/links.json b/airbyte-integrations/connectors/source-shortio/source_shortio/schemas/links.json
@@ -7,7 +7,7 @@
       "type": ["null", "string"]
     },
     "passwordContact": {
-      "type": ["null", "string"]
+      "type": ["null", "boolean"]
     },
     "hasPassword": {
       "type": ["null", "boolean"]

diff --git a/docs/integrations/sources/shortio.md b/docs/integrations/sources/shortio.md
@@ -16,19 +16,19 @@ This Source is capable of syncing the following Streams:
 ### Data type mapping
 
 | Integration Type | Airbyte Type | Notes |
-| :--- | :--- | :--- |
-| `string` | `string` |  |
-| `number` | `number` |  |
-| `array` | `array` |  |
-| `object` | `object` |  |
+|:-----------------|:-------------|:------|
+| `string`         | `string`     |       |
+| `number`         | `number`     |       |
+| `array`          | `array`      |       |
+| `object`         | `object`     |       |
 
 ### Features
 
-| Feature | Supported?\(Yes/No\) | Notes |
-| :--- | :--- | :--- |
-| Full Refresh Sync | Yes |  |
-| Incremental - Append Sync | Yes |  |
-| Namespaces | No |  |
+| Feature                   | Supported?\(Yes/No\) | Notes |
+|:--------------------------|:---------------------|:------|
+| Full Refresh Sync         | Yes                  |       |
+| Incremental - Append Sync | Yes                  |       |
+| Namespaces                | No                   |       |
 
 ## Getting started
 
@@ -39,11 +39,12 @@ This Source is capable of syncing the following Streams:
 
 ## Changelog
 
-| Version | Date       | Pull Request                                             | Subject                                                            |
-| :------ | :--------- | :------------------------------------------------------- | :----------------------------------------------------------------- |
-|  0.2.0  | 2023-08-02 | [28950](https://github.com/airbytehq/airbyte/pull/28950) | Migrate to Low-Code CDK                                            |
-|  0.1.3  | 2022-08-01 | [15066](https://github.com/airbytehq/airbyte/pull/15066) | Update primary key to `idString`                                   |
-|  0.1.2  | 2021-12-28 | [8628](https://github.com/airbytehq/airbyte/pull/8628)   | Update fields in source-connectors specifications                  |
-|  0.1.1  | 2021-11-08 | [7499](https://github.com/airbytehq/airbyte/pull/7499)   | Remove base-python dependencies                                    |
-|  0.1.0  | 2021-08-16 | [3787](https://github.com/airbytehq/airbyte/pull/5418)   | Add Native Shortio Source Connector                                |
+| Version | Date       | Pull Request                                             | Subject                                           |
+|:--------|:-----------|:---------------------------------------------------------|:--------------------------------------------------|
+| 0.2.1   | 2024-05-02 | [37597](https://github.com/airbytehq/airbyte/pull/37597) | Change `last_records` to `last_record`            |
+| 0.2.0   | 2023-08-02 | [28950](https://github.com/airbytehq/airbyte/pull/28950) | Migrate to Low-Code CDK                           |
+| 0.1.3   | 2022-08-01 | [15066](https://github.com/airbytehq/airbyte/pull/15066) | Update primary key to `idString`                  |
+| 0.1.2   | 2021-12-28 | [8628](https://github.com/airbytehq/airbyte/pull/8628)   | Update fields in source-connectors specifications |
+| 0.1.1   | 2021-11-08 | [7499](https://github.com/airbytehq/airbyte/pull/7499)   | Remove base-python dependencies                   |
+| 0.1.0   | 2021-08-16 | [3787](https://github.com/airbytehq/airbyte/pull/5418)   | Add Native Shortio Source Connector               |