Destination dev null: rebase onto master (#46276)

Co-authored-by: Johnny Schmidt <[email protected]>
airbytehq · Sep 30, 2024 · 4b3533a · 4b3533a
1 parent 90a4f87
commit 4b3533a
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 8 deletions.
diff --git a/airbyte-integrations/connectors/destination-dev-null/build.gradle b/airbyte-integrations/connectors/destination-dev-null/build.gradle
@@ -6,7 +6,7 @@ plugins {
 airbyteBulkConnector {
     core = 'load'
     toolkits = []
-    cdk = '0.61'
+    cdk = 'local'
 }
 
 application {

diff --git a/airbyte-integrations/connectors/destination-dev-null/metadata.yaml b/airbyte-integrations/connectors/destination-dev-null/metadata.yaml
@@ -2,7 +2,7 @@ data:
   connectorSubtype: file
   connectorType: destination
   definitionId: a7bcc9d8-13b3-4e49-b80d-d020b90045e3
-  dockerImageTag: 0.7.0
+  dockerImageTag: 0.7.1
   dockerRepository: airbyte/destination-dev-null
   githubIssueLabel: destination-dev-null
   icon: airbyte.svg

diff --git a/...null/src/main/kotlin/io/airbyte/integrations/destination/dev_null/DevNullSpecification.kt b/...null/src/main/kotlin/io/airbyte/integrations/destination/dev_null/DevNullSpecification.kt
@@ -12,8 +12,8 @@ import com.fasterxml.jackson.annotation.JsonTypeInfo
 import com.fasterxml.jackson.annotation.JsonValue
 import com.kjetland.jackson.jsonSchema.annotations.JsonSchemaInject
 import com.kjetland.jackson.jsonSchema.annotations.JsonSchemaTitle
-import io.airbyte.cdk.command.ConfigurationJsonObjectBase
-import io.airbyte.cdk.spec.DestinationSpecificationInternal
+import io.airbyte.cdk.command.ConfigurationSpecification
+import io.airbyte.cdk.spec.DestinationSpecificationExtension
 import io.airbyte.protocol.models.v0.DestinationSyncMode
 import io.micronaut.context.annotation.Requires
 import jakarta.inject.Singleton
@@ -22,7 +22,7 @@ import javax.validation.constraints.Min
 
 sealed class TestDestination
 
-sealed class DevNullSpecification : ConfigurationJsonObjectBase() {
+sealed class DevNullSpecification : ConfigurationSpecification() {
     abstract val testDestination: TestDestination
 }
 
@@ -232,7 +232,7 @@ data class SilentDestinationCloud(
 
 /** Non-client-facing configuration. */
 @Singleton
-class DevNullSpecificationInternal : DestinationSpecificationInternal {
+class DevNullSpecificationExtension : DestinationSpecificationExtension {
     override val supportedSyncModes =
         listOf(
             DestinationSyncMode.OVERWRITE,

diff --git a/...on-dev-null/src/main/kotlin/io/airbyte/integrations/destination/dev_null/DevNullWriter.kt b/...on-dev-null/src/main/kotlin/io/airbyte/integrations/destination/dev_null/DevNullWriter.kt
@@ -22,7 +22,7 @@ import kotlinx.coroutines.delay
 class DevNullWriter(private val config: DevNullConfiguration) : DestinationWriter {
     private val log = KotlinLogging.logger {}
 
-    override fun getStreamLoader(stream: DestinationStream): StreamLoader {
+    override fun createStreamLoader(stream: DestinationStream): StreamLoader {
         return when (config.type) {
             is Logging -> {
                 log.info { "Creating LoggingStreamLoader for LoggingDestination" }

diff --git a/docs/integrations/destinations/dev-null.md b/docs/integrations/destinations/dev-null.md
@@ -49,6 +49,7 @@ The OSS and Cloud variants have the same version number starting from version `0
 
 | Version | Date       | Pull Request                                             | Subject                                                    |
 |:--------|:-----------|:---------------------------------------------------------|:-----------------------------------------------------------|
+| 0.7.1   | 2024-09-30 | [46276](https://github.com/airbytehq/airbyte/pull/46276) | Upgrade to latest bulk CDK                                 |
 | 0.7.0   | 2024-09-20 | [45704](https://github.com/airbytehq/airbyte/pull/45704) |                                                            |
 | 0.6.1   | 2024-09-20 | [45715](https://github.com/airbytehq/airbyte/pull/45715) | add destination to cloud registry                          |
 | 0.6.0   | 2024-09-18 | [45651](https://github.com/airbytehq/airbyte/pull/45651) | merge destination-e2e(OSS) and destination-dev-null(cloud) |
@@ -69,4 +70,4 @@ The OSS and Cloud variants have the same version number starting from version `0
 | 0.2.0   | 2021-12-16 | [\#8824](https://github.com/airbytehq/airbyte/pull/8824) | Add multiple logging modes.                                |
 | 0.1.0   | 2021-05-25 | [\#3290](https://github.com/airbytehq/airbyte/pull/3290) | Create initial version.                                    |
 
-</details>
+</details>