🐛 Source Quickbooks: Change fields from integer to number (#30770)

Co-authored-by: Mahesh T <[email protected]> Co-authored-by: freyamade <[email protected]>
airbytehq · Sep 27, 2023 · 96f022b · 96f022b
1 parent 86e2b48
commit 96f022b
Show file tree

Hide file tree

Showing 9 changed files with 32 additions and 22 deletions.
diff --git a/airbyte-integrations/connectors/source-quickbooks/Dockerfile b/airbyte-integrations/connectors/source-quickbooks/Dockerfile
@@ -34,5 +34,5 @@ COPY source_quickbooks ./source_quickbooks
 ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/main.py"
 ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]
 
-LABEL io.airbyte.version=2.0.5
+LABEL io.airbyte.version=3.0.0
 LABEL io.airbyte.name=airbyte/source-quickbooks
diff --git a/airbyte-integrations/connectors/source-quickbooks/metadata.yaml b/airbyte-integrations/connectors/source-quickbooks/metadata.yaml
@@ -7,7 +7,7 @@ data:
   connectorSubtype: api
   connectorType: source
   definitionId: cf9c4355-b171-4477-8f2d-6c5cc5fc8b7e
-  dockerImageTag: 2.0.5
+  dockerImageTag: 3.0.0
   dockerRepository: airbyte/source-quickbooks
   githubIssueLabel: source-quickbooks
   icon: quickbooks.svg
@@ -19,6 +19,11 @@ data:
     oss:
       enabled: true
   releaseStage: alpha
+  releases:
+    breakingChanges:
+      3.0.0:
+        message: "Some fields in `bills`, `credit_memos`, `items`, `refund_receipts`, and `sales_receipts` streams have been changed from `integer` to `number` to fix normalization. You may need to refresh the connection schema for those streams (skipping the reset), and running a sync. Alternatively, you can just run a reset."
+        upgradeDeadline: 2023-10-04
   documentationUrl: https://docs.airbyte.com/integrations/sources/quickbooks
   tags:
     - language:low-code

diff --git a/airbyte-integrations/connectors/source-quickbooks/source_quickbooks/schemas/bills.json b/airbyte-integrations/connectors/source-quickbooks/source_quickbooks/schemas/bills.json
@@ -121,7 +121,7 @@
                 "type": ["null", "string"]
               },
               "UnitPrice": {
-                "type": ["null", "integer"]
+                "type": ["null", "number"]
               }
             },
             "type": ["null", "object"]

diff --git a/...yte-integrations/connectors/source-quickbooks/source_quickbooks/schemas/credit_memos.json b/...yte-integrations/connectors/source-quickbooks/source_quickbooks/schemas/credit_memos.json
@@ -28,7 +28,7 @@
       "type": ["null", "string"]
     },
     "Balance": {
-      "type": ["null", "integer"]
+      "type": ["null", "number"]
     },
     "CustomerMemo": {
       "properties": {
@@ -81,7 +81,7 @@
                 "type": ["null", "object"]
               },
               "UnitPrice": {
-                "type": ["null", "integer"]
+                "type": ["null", "number"]
               },
               "TaxCodeRef": {
                 "properties": {
@@ -224,7 +224,7 @@
       "type": ["null", "object"]
     },
     "RemainingCredit": {
-      "type": ["null", "integer"]
+      "type": ["null", "number"]
     },
     "ExchangeRate": {
       "type": ["null", "number"]

diff --git a/airbyte-integrations/connectors/source-quickbooks/source_quickbooks/schemas/items.json b/airbyte-integrations/connectors/source-quickbooks/source_quickbooks/schemas/items.json
@@ -73,7 +73,7 @@
       "type": ["null", "integer"]
     },
     "UnitPrice": {
-      "type": ["null", "integer"]
+      "type": ["null", "number"]
     },
     "SyncToken": {
       "type": ["null", "string"]

diff --git a/...-integrations/connectors/source-quickbooks/source_quickbooks/schemas/refund_receipts.json b/...-integrations/connectors/source-quickbooks/source_quickbooks/schemas/refund_receipts.json
@@ -78,7 +78,7 @@
                 "type": ["null", "object"]
               },
               "UnitPrice": {
-                "type": ["null", "integer"]
+                "type": ["null", "number"]
               }
             },
             "type": ["null", "object"]

diff --git a/...e-integrations/connectors/source-quickbooks/source_quickbooks/schemas/sales_receipts.json b/...e-integrations/connectors/source-quickbooks/source_quickbooks/schemas/sales_receipts.json
@@ -166,7 +166,7 @@
                 "type": ["null", "number"]
               },
               "UnitPrice": {
-                "type": ["null", "integer"]
+                "type": ["null", "number"]
               },
               "TaxCodeRef": {
                 "type": ["null", "object"],

diff --git a/docs/integrations/sources/quickbooks-migrations.md b/docs/integrations/sources/quickbooks-migrations.md
@@ -0,0 +1,4 @@
+# QuickBooks Migration Guide
+
+## Upgrading to 3.0.0
+Some fields in `bills`, `credit_memos`, `items`, `refund_receipts`, and `sales_receipts` streams have been changed from `integer` to `number` to fix normalization. You may need to refresh the connection schema for those streams (skipping the reset), and running a sync. Alternatively, you can just run a reset.
diff --git a/docs/integrations/sources/quickbooks.md b/docs/integrations/sources/quickbooks.md
@@ -103,16 +103,17 @@ This Source is capable of syncing the following [Streams](https://developer.intu
 
 ## Changelog
 
-| Version | Date       | Pull Request                                             | Subject                                                            |
-| :------ | :--------- | :------------------------------------------------------- | :----------------------------------------------------------------- |
-| `2.0.5` | 2023-09-26 | [30766](https://github.com/airbytehq/airbyte/pull/30766) | Fix improperly named keyword argument
-| `2.0.4` | 2023-06-28 | [27803](https://github.com/airbytehq/airbyte/pull/27803) | Update following state breaking changes                            |
-| `2.0.3` | 2023-06-08 | [27148](https://github.com/airbytehq/airbyte/pull/27148) | Update description and example values of a Start Date in spec.json |
-| `2.0.2` | 2023-06-07 | [26722](https://github.com/airbytehq/airbyte/pull/27053) | Update CDK version and adjust authenticator configuration          |
-| `2.0.1` | 2023-05-28 | [26722](https://github.com/airbytehq/airbyte/pull/26722) | Change datatype for undisclosed amount field in payments           |
-| `2.0.0` | 2023-04-11 | [25045](https://github.com/airbytehq/airbyte/pull/25045) | Fix datetime format, disable OAuth button in cloud                 |
-| `1.0.0` | 2023-03-20 | [24324](https://github.com/airbytehq/airbyte/pull/24324) | Migrate to Low-Code                                                |
-| `0.1.5` | 2022-02-17 | [10346](https://github.com/airbytehq/airbyte/pull/10346) | Update label `Quickbooks` -> `QuickBooks`                          |
-| `0.1.4` | 2021-12-20 | [8960](https://github.com/airbytehq/airbyte/pull/8960)   | Update connector fields title/description                          |
-| `0.1.3` | 2021-08-10 | [4986](https://github.com/airbytehq/airbyte/pull/4986)   | Using number data type for decimal fields instead string           |
-| `0.1.2` | 2021-07-06 | [4539](https://github.com/airbytehq/airbyte/pull/4539)   | Add `AIRBYTE_ENTRYPOINT` for Kubernetes support                    |
+| Version | Date       | Pull Request                                             | Subject                                                              |
+| :------ | :--------- | :------------------------------------------------------- | :------------------------------------------------------------------- |
+| `3.0.0` | 2023-09-26 | [30770](https://github.com/airbytehq/airbyte/pull/30770) | Update schema to use `number` instead of `integer`                   |
+| `2.0.5` | 2023-09-26 | [30766](https://github.com/airbytehq/airbyte/pull/30766) | Fix improperly named keyword argument                                |
+| `2.0.4` | 2023-06-28 | [27803](https://github.com/airbytehq/airbyte/pull/27803) | Update following state breaking changes                              |
+| `2.0.3` | 2023-06-08 | [27148](https://github.com/airbytehq/airbyte/pull/27148) | Update description and example values of a Start Date in spec.json   |
+| `2.0.2` | 2023-06-07 | [26722](https://github.com/airbytehq/airbyte/pull/27053) | Update CDK version and adjust authenticator configuration            |
+| `2.0.1` | 2023-05-28 | [26722](https://github.com/airbytehq/airbyte/pull/26722) | Change datatype for undisclosed amount field in payments             |
+| `2.0.0` | 2023-04-11 | [25045](https://github.com/airbytehq/airbyte/pull/25045) | Fix datetime format, disable OAuth button in cloud                   |
+| `1.0.0` | 2023-03-20 | [24324](https://github.com/airbytehq/airbyte/pull/24324) | Migrate to Low-Code                                                  |
+| `0.1.5` | 2022-02-17 | [10346](https://github.com/airbytehq/airbyte/pull/10346) | Update label `Quickbooks` -> `QuickBooks`                            |
+| `0.1.4` | 2021-12-20 | [8960](https://github.com/airbytehq/airbyte/pull/8960)   | Update connector fields title/description                            |
+| `0.1.3` | 2021-08-10 | [4986](https://github.com/airbytehq/airbyte/pull/4986)   | Using number data type for decimal fields instead string             |
+| `0.1.2` | 2021-07-06 | [4539](https://github.com/airbytehq/airbyte/pull/4539)   | Add `AIRBYTE_ENTRYPOINT` for Kubernetes support                      |