Skip to content

Commit

Permalink
Undo WIP.
Browse files Browse the repository at this point in the history
  • Loading branch information
davinchia committed Dec 19, 2023
1 parent 6af53c5 commit e197441
Showing 1 changed file with 13 additions and 25 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -348,31 +348,6 @@ static void consumeWriteStream(final SerializedAirbyteMessageConsumer consumer,
}
}

/**
* @param connectorImage Expected format: [organization/]image[:version]
*/
@VisibleForTesting
static String parseConnectorVersion(final String connectorImage) {
if (connectorImage == null || connectorImage.equals("")) {
return "unknown";
}

final String[] tokens = connectorImage.split(":");
return tokens[tokens.length - 1];
}

@VisibleForTesting
static void swallowIteratorCloseErrors(AutoCloseableIterator<AirbyteMessage> iter, Callable runner) {
runner.call();
try {
iter.close();
} catch (Exception e) {
LOGGER.warn("Exception closing connection: {}. This is generally fine as we've moved all data & are terminating everything. ",
e.getMessage());
}

}

/**
* Stops any non-daemon threads that could block the JVM from exiting when the main thread is done.
* <p>
Expand Down Expand Up @@ -451,4 +426,17 @@ private static <T> T parseConfig(final Path path, final Class<T> klass) {
return Jsons.object(jsonNode, klass);
}

/**
* @param connectorImage Expected format: [organization/]image[:version]
*/
@VisibleForTesting
static String parseConnectorVersion(final String connectorImage) {
if (connectorImage == null || connectorImage.equals("")) {
return "unknown";
}

final String[] tokens = connectorImage.split(":");
return tokens[tokens.length - 1];
}

}

0 comments on commit e197441

Please sign in to comment.