🐛 Source Shopify: Have comma separated tags for products stream (#38769)

airbytehq · May 29, 2024 · edcdd22 · edcdd22
1 parent c63d409
commit edcdd22
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 4 deletions.
diff --git a/airbyte-integrations/connectors/source-shopify/metadata.yaml b/airbyte-integrations/connectors/source-shopify/metadata.yaml
@@ -11,7 +11,7 @@ data:
   connectorSubtype: api
   connectorType: source
   definitionId: 9da77001-af33-4bcd-be46-6252bf9342b9
-  dockerImageTag: 2.2.0
+  dockerImageTag: 2.2.1
   dockerRepository: airbyte/source-shopify
   documentationUrl: https://docs.airbyte.com/integrations/sources/shopify
   githubIssueLabel: source-shopify

diff --git a/airbyte-integrations/connectors/source-shopify/pyproject.toml b/airbyte-integrations/connectors/source-shopify/pyproject.toml
@@ -3,7 +3,7 @@ requires = [ "poetry-core>=1.0.0",]
 build-backend = "poetry.core.masonry.api"
 
 [tool.poetry]
-version = "2.2.0"
+version = "2.2.1"
 name = "source-shopify"
 description = "Source CDK implementation for Shopify."
 authors = [ "Airbyte <[email protected]>",]

diff --git a/airbyte-integrations/connectors/source-shopify/source_shopify/shopify_graphql/bulk/query.py b/airbyte-integrations/connectors/source-shopify/source_shopify/shopify_graphql/bulk/query.py
@@ -1672,11 +1672,11 @@ def _process_options(self, options: List[dict], product_id: Optional[int] = None
             option["product_id"] = product_id if product_id else None
         return options
 
-    def _unnest_tags(self, record: MutableMapping[str, Any]) -> str:
+    def _unnest_tags(self, record: MutableMapping[str, Any]) -> Optional[str]:
         # we keep supporting 1 tag only, as it was for the REST stream,
         # to avoid breaking change.
         tags = record.get("tags", [])
-        return tags[0] if len(tags) > 0 else None
+        return ", ".join(tags) if tags else None
 
     def record_process_components(self, record: MutableMapping[str, Any]) -> Iterable[MutableMapping[str, Any]]:
         """

diff --git a/docs/integrations/sources/shopify.md b/docs/integrations/sources/shopify.md
@@ -208,6 +208,7 @@ For all `Shopify GraphQL BULK` api requests these limitations are applied: https
 
 | Version | Date       | Pull Request                                             | Subject                                                                                                                                                                                                                                                                                                                                                                                   |
 | :------ |:-----------| :------------------------------------------------------- | :---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
+| 2.2.1   | 2024-05-30 | [38769](https://github.com/airbytehq/airbyte/pull/38769) | Have products stream return all the tags comma separated |
 | 2.2.0   | 2024-05-29 | [38746](https://github.com/airbytehq/airbyte/pull/38746) | Updated countries schema |
 | 2.1.4   | 2024-05-24 | [38610](https://github.com/airbytehq/airbyte/pull/38610) | Updated the source `API Version` to `2024-04` |
 | 2.1.3   | 2024-05-23 | [38464](https://github.com/airbytehq/airbyte/pull/38464) | Added missing fields to `Products` stream |