remove dockerfile for source-zendesk-chat and implement build_customi…

…zation.py
airbytehq · Oct 11, 2023 · fcecb62 · fcecb62
1 parent 987bb9e
commit fcecb62
Show file tree

Hide file tree

Showing 4 changed files with 27 additions and 21 deletions.
diff --git a/airbyte-integrations/connectors/source-zendesk-chat/Dockerfile b/airbyte-integrations/connectors/source-zendesk-chat/Dockerfile
diff --git a/airbyte-integrations/connectors/source-zendesk-chat/build_customization.py b/airbyte-integrations/connectors/source-zendesk-chat/build_customization.py
@@ -0,0 +1,23 @@
+#
+# Copyright (c) 2023 Airbyte, Inc., all rights reserved.
+#
+from __future__ import annotations
+
+from typing import TYPE_CHECKING
+
+if TYPE_CHECKING:
+    from dagger import Container
+
+MAIN_FILE_NAME = "main_dev.py"
+
+
+async def pre_connector_install(base_image_container: Container) -> Container:
+    """This function will run before the connector installation.
+    We set these environment variable to match what was originally in the Dockerfile.
+    Disclaimer: I have no idea if these env vars are actually needed.
+    """
+    return await (
+        base_image_container.with_env_variable("AIRBYTE_IMPL_MODULE", "source_zendesk_chat").with_env_variable(
+            "AIRBYTE_IMPL_PATH", "SourceZendeskChat"
+        )
+    )
diff --git a/airbyte-integrations/connectors/source-zendesk-chat/metadata.yaml b/airbyte-integrations/connectors/source-zendesk-chat/metadata.yaml
@@ -2,10 +2,12 @@ data:
   allowedHosts:
     hosts:
       - zopim.com
+  connectorBuildOptions:
+    baseImage: airbyte/python-connector-base:1.0.0
   connectorSubtype: api
   connectorType: source
   definitionId: 40d24d0f-b8f9-4fe0-9e6c-b06c0f3f45e4
-  dockerImageTag: 0.1.14
+  dockerImageTag: 0.2.0
   dockerRepository: airbyte/source-zendesk-chat
   githubIssueLabel: source-zendesk-chat
   icon: zendesk-chat.svg

diff --git a/docs/integrations/sources/zendesk-chat.md b/docs/integrations/sources/zendesk-chat.md
@@ -80,6 +80,7 @@ The connector is restricted by Zendesk's [requests limitation](https://developer
 
 | Version | Date       | Pull Request                                             | Subject                                                                                                          |
 | :------ | :--------- | :------------------------------------------------------- | :--------------------------------------------------------------------------------------------------------------- |
+| 0.2.0  | 2023-10-11 | [30526](https://github.com/airbytehq/airbyte/pull/30526) | Use the python connector base image, remove dockerfile and implement build_customization.py                                                                   |
 | 0.1.14  | 2023-02-10 | [24190](https://github.com/airbytehq/airbyte/pull/24190) | Fix remove too high min/max from account stream                                                                  |
 | 0.1.13  | 2023-02-10 | [22819](https://github.com/airbytehq/airbyte/pull/22819) | Specified date formatting in specification                                                                       |
 | 0.1.12  | 2023-01-27 | [22026](https://github.com/airbytehq/airbyte/pull/22026) | Set `AvailabilityStrategy` for streams explicitly to `None`                                                      |