Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A single base for all python connectors #30231

Closed
alafanechere opened this issue Sep 7, 2023 · 2 comments
Closed

A single base for all python connectors #30231

alafanechere opened this issue Sep 7, 2023 · 2 comments

Comments

@alafanechere
Copy link
Contributor

Tech spec

@alafanechere
Copy link
Contributor Author

Weekly project update: A single base image for all python connectors

What was done:

  • Tech spec is ratified. We picked the following final direction:
    • Our base images will be declared in code.
    • Certified connectors won’t have Dockerfile anymore and will use this base image
    • A system of pre/post build hooks will allow customization of connector build.
    • Community connectors can still have Dockerfiles.
  • We ran a thorough ad hoc analysis of our existing certified connectors Dockerfile to assess what should be bundled in the base image and how the connectors should be built.
  • We added a new connectorBuildOptions.baseImage metadata field. It’ll be used by our build process to define what base image a connector will use.

What’s we want to ship this week:

  • Implement a framework that will allow us to manage and version base images. And declare the first base image version.
  • Refactor our connector build process in airbyte-ci/connectors/pipeline to use the first base image version.
  • Make two connectors use the base image.

What’s next:
Feel free to take a look at the issues linked to this epic.

@alafanechere
Copy link
Contributor Author

Weekly project update: A base image for all python connectors

What was done:

What we want to ship this week:

  • A good portion of the work mentioned above is still on stacked PR. We’d love it to hit master before the end of the week. Reviews and additional testing required.
  • Start migrating certified python connectors to make them use our first base image and delete their dockerfiles.

What got in the way

Healthy but lengthy design discussions on this PR slowed down the delivery. I think it’s for the best: solid bases will prevent a growing tech debt on this project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant