-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
redelete connector dockerfiles #31228
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
source-github test report (commit
|
Step | Result |
---|---|
Connector package install | ✅ |
Build source-github docker image for platform(s) linux/x86_64 | ❌ |
Code format checks | ✅ |
Validate metadata for source-github | ✅ |
Connector version semver check | ✅ |
Connector version increment check | ❌ |
QA checks | ❌ |
☁️ View runs for commit in Dagger Cloud
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-github test
source-google-ads test report (commit
|
Step | Result |
---|---|
Connector package install | ✅ |
Build source-google-ads docker image for platform(s) linux/x86_64 | ❌ |
Code format checks | ✅ |
Validate metadata for source-google-ads | ✅ |
Connector version semver check | ✅ |
Connector version increment check | ❌ |
QA checks | ❌ |
☁️ View runs for commit in Dagger Cloud
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-google-ads test
source-mixpanel test report (commit
|
Step | Result |
---|---|
Connector package install | ✅ |
Build source-mixpanel docker image for platform(s) linux/x86_64 | ❌ |
Code format checks | ✅ |
Validate metadata for source-mixpanel | ✅ |
Connector version semver check | ✅ |
Connector version increment check | ❌ |
QA checks | ❌ |
☁️ View runs for commit in Dagger Cloud
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-mixpanel test
destination-pinecone test report (commit
|
Step | Result |
---|---|
Connector package install | ✅ |
Build destination-pinecone docker image for platform(s) linux/x86_64 | ❌ |
Code format checks | ✅ |
Validate metadata for destination-pinecone | ✅ |
Connector version semver check | ✅ |
Connector version increment check | ❌ |
QA checks | ❌ |
☁️ View runs for commit in Dagger Cloud
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=destination-pinecone test
destination-qdrant test report (commit
|
Step | Result |
---|---|
Connector package install | ✅ |
Build destination-qdrant docker image for platform(s) linux/x86_64 | ❌ |
Code format checks | ✅ |
Validate metadata for destination-qdrant | ✅ |
Connector version semver check | ✅ |
Connector version increment check | ❌ |
QA checks | ❌ |
☁️ View runs for commit in Dagger Cloud
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=destination-qdrant test
destination-chroma test report (commit
|
Step | Result |
---|---|
Connector package install | ✅ |
Build destination-chroma docker image for platform(s) linux/x86_64 | ❌ |
Code format checks | ✅ |
Validate metadata for destination-chroma | ✅ |
Connector version semver check | ✅ |
Connector version increment check | ❌ |
QA checks | ❌ |
☁️ View runs for commit in Dagger Cloud
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=destination-chroma test
source-google-analytics-data-api test report (commit
|
Step | Result |
---|---|
Connector package install | ✅ |
Build source-google-analytics-data-api docker image for platform(s) linux/x86_64 | ❌ |
Code format checks | ✅ |
Validate metadata for source-google-analytics-data-api | ✅ |
Connector version semver check | ✅ |
Connector version increment check | ❌ |
QA checks | ❌ |
☁️ View runs for commit in Dagger Cloud
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-google-analytics-data-api test
destination-milvus test report (commit
|
Step | Result |
---|---|
Connector package install | ✅ |
Build destination-milvus docker image for platform(s) linux/x86_64 | ❌ |
Code format checks | ✅ |
Validate metadata for destination-milvus | ✅ |
Connector version semver check | ✅ |
Connector version increment check | ❌ |
QA checks | ❌ |
☁️ View runs for commit in Dagger Cloud
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=destination-milvus test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
connectors shouldn't (?) need explicit dockerfiles anymore. #30743 attempted to delete them, but accidentally re-added some in a merge commit (0e946d2). This PR just re-deletes those dockerfiles.
find airbyte-integrations/connectors -name Dockerfile
still shows a lot of dockerfiles, and it's not clear to me why they need to remain. In the interest of making forward progress, I'm just deleting the ones that we tried to delete earlier.