low-code: Remove NoPagination from the interface #24978
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octavia-squidington-iii
added
area/connectors
octavia-squidington-iii
added
connectors/source/intercom
connectors/source/monday
connectors/source/sentry
connectors/source/close-com
connectors/source/facebook-pages
connectors/source/sendgrid
connectors/source/chartmogul
connectors/source/metabase
connectors/source/braze
connectors/source/instatus
connectors/source/clickup-api
connectors/source/whisky-hunter
connectors/source/waiteraid
connectors/source/zoom
connectors/source/coingecko-coins
connectors/source/coin-api
connectors/source/spacex-api
connectors/source/alpha-vantage
connectors/source/mailjet-mail
connectors/source/tvmaze-schedule
connectors/source/mailerlite
connectors/source/wikipedia-pageviews
connectors/source/mailjet-sms
connectors/source/k6-cloud
connectors/source/survey-sparrow
labels
octavia-squidington-iii
added
connectors/source/google-webfonts
connectors/source/toggl
connectors/source/tmdb
connectors/source/coinmarketcap
connectors/source/pypi
connectors/source/rocket-chat
connectors/source/emailoctopus
connectors/source/configcat
connectors/source/ip2whois
connectors/source/plausible
connectors/source/recruitee
connectors/source/smaily
connectors/source/smartengage
connectors/source/pendo
connectors/source/punk-api
connectors/source/nytimes
connectors/source/gnews
connectors/source/breezometer
connectors/source/polygon-stock-api
connectors/source/reply-io
connectors/source/pexels-api
connectors/source/tyntec-sms
connectors/source/everhour
connectors/source/sap-fieldglass
connectors/source/google-pagespeed-insights
connectors/source/dremio
connectors/source/unleash
labels
girarda
changed the title
girarda
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This is a follow up PR to #24976
The NoPagination object does not need to be exposed in the DSL because the SimpleRetriever's paginator field is optional.
This removes the NoPagination from the manifest schema so we don't need to document and maintain it.
How
DefaultPaginatorairbyte-cdk/python/airbyte_cdk/sources/declarative/parsers/class_types_registry.pybecause it is not used anymoreairbyte-cdk/python/airbyte_cdk/sources/declarative/parsers/default_implementation_registry.pybecause it is not used anymoreRecommended reading order
airbyte-cdk/python/airbyte_cdk/sources/declarative/declarative_component_schema.yamlairbyte-cdk/python/airbyte_cdk/sources/declarative/models/declarative_component_schema.pydocs/connector-development/config-based/tutorial/3-connecting-to-the-API-source.mddocs/connector-development/config-based/tutorial/5-incremental-reads.mddocs/connector-development/config-based/understanding-the-yaml-file/pagination.md