-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[airbyte-ci] build python connectors from base images #30456
[airbyte-ci] build python connectors from base images #30456
Conversation
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
9350c16
to
3e01715
Compare
e5e4d7b
to
2aef971
Compare
2aef971
to
41ce5f5
Compare
41ce5f5
to
b387477
Compare
4dfe568
to
3abf079
Compare
b387477
to
0113f6a
Compare
3abf079
to
31afb94
Compare
157ca30
to
894e0b9
Compare
31afb94
to
de3eeb1
Compare
source-auth0 test report (commit
|
Step | Result |
---|---|
Connector package install | ✅ |
Build source-auth0 docker image for platform(s) linux/x86_64 | ✅ |
Acceptance tests | ✅ |
Code format checks | ✅ |
Validate metadata for source-auth0 | ✅ |
Connector version semver check | ✅ |
QA checks | ✅ |
☁️ View runs for commit in Dagger Cloud
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-auth0 test
@bnchrch and @pedroslopez I reverted the changes for source-file-(secure). Why:
I suggest to fix and bump both of these connector (and 🪓 the source-file Dockerfile) in a separate PR (I'll take car of it). This leads to a temporary code freeze on source-file. |
source-auth0 test report (commit
|
Step | Result |
---|---|
Connector package install | ✅ |
Build source-auth0 docker image for platform(s) linux/x86_64 | ✅ |
Acceptance tests | ✅ |
Code format checks | ✅ |
Validate metadata for source-auth0 | ✅ |
Connector version semver check | ✅ |
QA checks | ✅ |
☁️ View runs for commit in Dagger Cloud
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-auth0 test
…the_base_images' of github.com:airbytehq/airbyte into 09-14-change_our_python_connector_build_process_to_use_the_base_images
source-auth0 test report (commit
|
Step | Result |
---|---|
Connector package install | ✅ |
Build source-auth0 docker image for platform(s) linux/x86_64 | ✅ |
Acceptance tests | ✅ |
Code format checks | ✅ |
Validate metadata for source-auth0 | ✅ |
Connector version semver check | ✅ |
QA checks | ✅ |
☁️ View runs for commit in Dagger Cloud
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-auth0 test
source-auth0 test report (commit
|
Step | Result |
---|---|
Connector package install | ✅ |
Build source-auth0 docker image for platform(s) linux/x86_64 | ✅ |
Acceptance tests | ✅ |
Code format checks | ✅ |
Validate metadata for source-auth0 | ✅ |
Connector version semver check | ✅ |
QA checks | ✅ |
☁️ View runs for commit in Dagger Cloud
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-auth0 test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Ben Church <[email protected]> Co-authored-by: bnchrch <[email protected]> Co-authored-by: alafanechere <[email protected]>
What
Closes #30236
Make our Python connector build step use the base image versions declared in the
airbyte-connectors-base-images
package.
How
BuildConnectorImage
to build a connector from the base image version it defined in the metadata,otherwise fallback to a dockerfile build.
🚨 User Impact 🚨
Any connector declaring the
baseImage
metadata field will get built using the base image instead of its Dockerfile.Next steps:
Implement the pre/post build hook logic: #30526