Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Amplitude: fix data region keyerror #30525

Merged

Conversation

roman-yermilov-gl
Copy link
Contributor

What

How

  • Take value from a dictionary in a safe way
  • Add some comments

@github-actions
Copy link
Contributor

github-actions bot commented Sep 18, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Sep 18, 2023
@roman-yermilov-gl roman-yermilov-gl marked this pull request as ready for review September 18, 2023 14:21
@github-actions
Copy link
Contributor

source-amplitude test report (commit 7bc744ddd7) - ✅

⏲️ Total pipeline duration: 14mn56s

Step Result
Connector package install
Build source-amplitude docker image for platform linux/x86_64
Unit tests
Acceptance tests
Code format checks
Validate airbyte-integrations/connectors/source-amplitude/metadata.yaml
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-amplitude test

@roman-yermilov-gl roman-yermilov-gl changed the title Ryermilov/source amplitude fix data region keyerror Source Amplitude: fix data region keyerror Sep 19, 2023
Copy link
Collaborator

@lazebnyi lazebnyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need update doc, after that good to go.

@@ -36,7 +36,7 @@ def streams(self, config: Mapping[str, Any]) -> List[Stream]:
Events(
authenticator=auth,
start_date=config["start_date"],
data_region=config["data_region"],
data_region=config.get("data_region", "Standard Server"),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add info about default value to doc

@roman-yermilov-gl roman-yermilov-gl merged commit 037b2cf into master Sep 19, 2023
3 checks passed
@roman-yermilov-gl roman-yermilov-gl deleted the ryermilov/source-amplitude-fix-data_region-keyerror branch September 19, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/amplitude
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants