Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source Marketo: fix json_schema for stream Leads #30533

Merged
merged 6 commits into from
Sep 19, 2023
Merged

Source Marketo: fix json_schema for stream Leads #30533

merged 6 commits into from
Sep 19, 2023

Conversation

artem1205
Copy link
Collaborator

@artem1205 artem1205 commented Sep 18, 2023 •
edited
Loading

What

Filter out not available fields from request

How

Filter out not available fields from request.

TODO: dynamically create json_schema
Blocked by: https://github.com/airbytehq/airbyte-internal-issues/issues/2100

Recommended reading order

  1. streams.py

🚨 User Impact 🚨

no breaking changes

Pre-merge Actions

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Unit & integration tests added

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.

@artem1205 artem1205 changed the title Source Marketo: fix schema Source Marketo: fix json_schema for stream Leads Sep 18, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 18, 2023 •
edited by artem1205
Loading

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Sep 18, 2023
@artem1205 artem1205 self-assigned this Sep 18, 2023
@artem1205 artem1205 marked this pull request as ready for review September 18, 2023 16:37
@github-actions
Copy link
Contributor

source-marketo test report (commit 90b21a5106) - ❌

⏲️ Total pipeline duration: 23mn16s

Step Result
Connector package install ✅
Build source-marketo docker image for platform linux/x86_64 ✅
Unit tests ✅
Acceptance tests ❌
Code format checks ✅
Validate airbyte-integrations/connectors/source-marketo/metadata.yaml ✅
Connector version semver check ✅
Connector version increment check ✅
QA checks ✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-marketo test

@github-actions
Copy link
Contributor

source-marketo test report (commit 79331b4936) - ✅

⏲️ Total pipeline duration: 70mn46s

Step Result
Connector package install ✅
Build source-marketo docker image for platform linux/x86_64 ✅
Unit tests ✅
Acceptance tests ✅
Code format checks ✅
Validate airbyte-integrations/connectors/source-marketo/metadata.yaml ✅
Connector version semver check ✅
Connector version increment check ✅
QA checks ✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-marketo test

lazebnyi
lazebnyi approved these changes Sep 19, 2023
View reviewed changes
Copy link
Collaborator

@lazebnyi lazebnyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need update doc, after that good to go.

airbyte-integrations/connectors/source-marketo/source_marketo/source.py

def get_json_schema(self) -> Mapping[str, Any]:
# TODO: make schema truly dynamic like in stream Activities
# now blocked by https://github.com/airbytehq/airbyte/issues/30530 due to potentially > 500 fields in schema (can cause OOM)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add this info to doc file, that we have limits for fields qty now.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

@github-actions
Copy link
Contributor

source-marketo test report (commit a1a84594a6) - ✅

⏲️ Total pipeline duration: 70mn26s

Step Result
Connector package install ✅
Build source-marketo docker image for platform linux/x86_64 ✅
Unit tests ✅
Acceptance tests ✅
Code format checks ✅
Validate airbyte-integrations/connectors/source-marketo/metadata.yaml ✅
Connector version semver check ✅
Connector version increment check ✅
QA checks ✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-marketo test

@artem1205 artem1205 merged commit f5a4eec into master Sep 19, 2023
18 checks passed
@artem1205 artem1205 deleted the artem1205/source-marketo-fix-schema-fields branch September 19, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lazebnyi lazebnyi lazebnyi approved these changes

@davydov-d davydov-d Awaiting requested review from davydov-d

Assignees

@artem1205 artem1205

Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/marketo
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@artem1205 @lazebnyi @octavia-squidington-iii