Source MySQL: Tagging MySQL variants as GA in metadata. Prep for Airbyte Certified/Bronze release #30558

prateekmukhedkar · 2023-09-18T22:49:59Z

Refer #28681, tagging as GA for internal visibility.

Tagging MySQL variants as GA in metadata

github-actions · 2023-09-18T22:50:23Z

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

PR name follows PR naming conventions
Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
Secrets in the connector's spec are annotated with airbyte_secret
All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

Check for hidden checklists in your PR description
Toggle the github label checklist-action-run on/off to re-run the checklist CI.

Set supportLevel as certified

github-actions · 2023-09-18T23:07:32Z

source-mysql test report (commit `a74aa63190`) - ❌

⏲️ Total pipeline duration: 01mn34s

Step	Result
Build connector tar	❌
Validate airbyte-integrations/connectors/source-mysql/metadata.yaml	✅
Connector version semver check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-mysql test

github-actions · 2023-09-18T23:19:37Z

source-mysql-strict-encrypt test report (commit `a74aa63190`) - ❌

⏲️ Total pipeline duration: 11mn43s

Step	Result
Build connector tar	✅
Build source-mysql-strict-encrypt docker image for platform linux/x86_64	✅
Java Connector Unit Tests	✅
Java Connector Integration Tests	❌
Acceptance tests	❌
Validate airbyte-integrations/connectors/source-mysql-strict-encrypt/metadata.yaml	✅
Connector version semver check	✅
QA checks	❌

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-mysql-strict-encrypt test

bnchrch

Ill leave the approval to the db sources team :)

But I updated the internal metadata fields to match the new support level!

https://www.notion.so/Internal-Metadata-Fields-32b02037e7b244b7934214019d0b7cc9?pvs=4

prateekmukhedkar · 2023-09-18T23:49:04Z

Ill leave the approval to the db sources team :)

But I updated the internal metadata fields to match the new support level!

https://www.notion.so/Internal-Metadata-Fields-32b02037e7b244b7934214019d0b7cc9?pvs=4

@bnchrch we want to publicly announce source-mysql as Airbyte certified. Should we bump ql to 300?

bnchrch · 2023-09-18T23:58:24Z

@prateekmukhedkar Feel free to! Its not required at this time but worth to point out that bumping of ql will increase the number of test cases that we certify source-mysql against.

In this case going to ql: 300 will require that you define the allowedHosts field in the metadata

Which it looks like you have! so I'd say there is no harm

Setting support level as Airbyte certified

github-actions · 2023-09-19T05:31:23Z

source-mysql test report (commit `3f5fb03bd0`) - ✅

⏲️ Total pipeline duration: 28mn48s

Step	Result
Build connector tar	✅
Build source-mysql docker image for platform linux/x86_64	✅
Java Connector Unit Tests	✅
Java Connector Integration Tests	✅
Acceptance tests	✅
Validate airbyte-integrations/connectors/source-mysql/metadata.yaml	✅
Connector version semver check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-mysql test

github-actions · 2023-09-19T05:39:02Z

source-mysql-strict-encrypt test report (commit `3f5fb03bd0`) - ❌

⏲️ Total pipeline duration: 07mn29s

Step	Result
Build connector tar	✅
Build source-mysql-strict-encrypt docker image for platform linux/x86_64	✅
Java Connector Unit Tests	✅
Java Connector Integration Tests	✅
Acceptance tests	❌
Validate airbyte-integrations/connectors/source-mysql-strict-encrypt/metadata.yaml	✅
Connector version semver check	✅
QA checks	❌

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-mysql-strict-encrypt test

vercel · 2023-09-19T21:24:46Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
airbyte-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 19, 2023 10:44pm

github-actions · 2023-09-19T21:56:08Z

source-mysql test report (commit `5f520bed5c`) - ✅

⏲️ Total pipeline duration: 29mn13s

Step	Result
Build connector tar	✅
Build source-mysql docker image for platform linux/x86_64	✅
Java Connector Unit Tests	✅
Java Connector Integration Tests	✅
Acceptance tests	✅
Validate airbyte-integrations/connectors/source-mysql/metadata.yaml	✅
Connector version semver check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-mysql test

github-actions · 2023-09-19T22:03:42Z

source-mysql-strict-encrypt test report (commit `5f520bed5c`) - ❌

⏲️ Total pipeline duration: 07mn24s

Step	Result
Build connector tar	✅
Build source-mysql-strict-encrypt docker image for platform linux/x86_64	✅
Java Connector Unit Tests	✅
Java Connector Integration Tests	✅
Acceptance tests	✅
Validate airbyte-integrations/connectors/source-mysql-strict-encrypt/metadata.yaml	✅
Connector version semver check	✅
QA checks	❌

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-mysql-strict-encrypt test

github-actions · 2023-09-19T22:44:52Z

source-mysql-strict-encrypt test report (commit `bb6dbab4be`) - ✅

⏲️ Total pipeline duration: 02mn54s

Step	Result
Build connector tar	✅
Build source-mysql-strict-encrypt docker image for platform linux/x86_64	✅
Java Connector Unit Tests	✅
Java Connector Integration Tests	✅
Acceptance tests	✅
Validate airbyte-integrations/connectors/source-mysql-strict-encrypt/metadata.yaml	✅
Connector version semver check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-mysql-strict-encrypt test

github-actions · 2023-09-19T22:47:13Z

source-mysql test report (commit `bb6dbab4be`) - ✅

⏲️ Total pipeline duration: 02mn12s

Step	Result
Build connector tar	✅
Build source-mysql docker image for platform linux/x86_64	✅
Java Connector Unit Tests	✅
Java Connector Integration Tests	✅
Acceptance tests	✅
Validate airbyte-integrations/connectors/source-mysql/metadata.yaml	✅
Connector version semver check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-mysql test

Tagging MySQL variants as GA in metadata

25ed470

Tagging MySQL variants as GA in metadata

prateekmukhedkar added the connectors/source/mysql label Sep 18, 2023

prateekmukhedkar requested a review from a team as a code owner September 18, 2023 22:49

octavia-squidington-iii added area/connectors Connector related issues connectors/source/mysql-strict-encrypt labels Sep 18, 2023

Set supportLevel as certified

a74aa63

Set supportLevel as certified

prateekmukhedkar requested review from akashkulk and bnchrch September 18, 2023 22:54

Increase ab_internal.sl to 200

cd66d26

bnchrch reviewed Sep 18, 2023

View reviewed changes

prateekmukhedkar changed the title ~~Tagging MySQL variants as GA in metadata~~ Tagging MySQL variants as GA in metadata. Prep for Airbyte Certified/Bronze release Sep 18, 2023

prateekmukhedkar and others added 2 commits September 18, 2023 17:04

Setting support level as Airbyte certified

3abdea6

Setting support level as Airbyte certified

Merge branch 'master' into prateekmukhedkar/tag-mysql-ga

3f5fb03

Merge branch 'master' into prateekmukhedkar/tag-mysql-ga

5f520be

vercel bot deployed to Preview September 19, 2023 21:29 View deployment

Merge branch 'master' into prateekmukhedkar/tag-mysql-ga

bb6dbab

vercel bot deployed to Preview September 19, 2023 22:44 View deployment

prateekmukhedkar changed the title ~~Tagging MySQL variants as GA in metadata. Prep for Airbyte Certified/Bronze release~~ Source MySQL: Tagging MySQL variants as GA in metadata. Prep for Airbyte Certified/Bronze release Sep 19, 2023

prateekmukhedkar enabled auto-merge (squash) September 19, 2023 23:22

akashkulk approved these changes Sep 19, 2023

View reviewed changes

prateekmukhedkar merged commit 1c0fd1b into master Sep 19, 2023
17 of 18 checks passed

prateekmukhedkar deleted the prateekmukhedkar/tag-mysql-ga branch September 19, 2023 23:38

prateekmukhedkar mentioned this pull request Sep 20, 2023

Source MySQL: Release Airbyte Certified MySQL Source connector #30620

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Source MySQL: Tagging MySQL variants as GA in metadata. Prep for Airbyte Certified/Bronze release #30558

Source MySQL: Tagging MySQL variants as GA in metadata. Prep for Airbyte Certified/Bronze release #30558

prateekmukhedkar commented Sep 18, 2023

github-actions bot commented Sep 18, 2023 •

edited by prateekmukhedkar

Loading

github-actions bot commented Sep 18, 2023

github-actions bot commented Sep 18, 2023

bnchrch left a comment

prateekmukhedkar commented Sep 18, 2023

bnchrch commented Sep 18, 2023

github-actions bot commented Sep 19, 2023

github-actions bot commented Sep 19, 2023

vercel bot commented Sep 19, 2023 •

edited

Loading

github-actions bot commented Sep 19, 2023

github-actions bot commented Sep 19, 2023

github-actions bot commented Sep 19, 2023

github-actions bot commented Sep 19, 2023

Source MySQL: Tagging MySQL variants as GA in metadata. Prep for Airbyte Certified/Bronze release #30558

Source MySQL: Tagging MySQL variants as GA in metadata. Prep for Airbyte Certified/Bronze release #30558

Conversation

prateekmukhedkar commented Sep 18, 2023

github-actions bot commented Sep 18, 2023 • edited by prateekmukhedkar Loading

Before Merging a Connector Pull Request

github-actions bot commented Sep 18, 2023

source-mysql test report (commit a74aa63190) - ❌

github-actions bot commented Sep 18, 2023

source-mysql-strict-encrypt test report (commit a74aa63190) - ❌

bnchrch left a comment

Choose a reason for hiding this comment

prateekmukhedkar commented Sep 18, 2023

bnchrch commented Sep 18, 2023

github-actions bot commented Sep 19, 2023

source-mysql test report (commit 3f5fb03bd0) - ✅

github-actions bot commented Sep 19, 2023

source-mysql-strict-encrypt test report (commit 3f5fb03bd0) - ❌

vercel bot commented Sep 19, 2023 • edited Loading

github-actions bot commented Sep 19, 2023

source-mysql test report (commit 5f520bed5c) - ✅

github-actions bot commented Sep 19, 2023

source-mysql-strict-encrypt test report (commit 5f520bed5c) - ❌

github-actions bot commented Sep 19, 2023

source-mysql-strict-encrypt test report (commit bb6dbab4be) - ✅

github-actions bot commented Sep 19, 2023

source-mysql test report (commit bb6dbab4be) - ✅

github-actions bot commented Sep 18, 2023 •

edited by prateekmukhedkar

Loading

source-mysql test report (commit `a74aa63190`) - ❌

source-mysql-strict-encrypt test report (commit `a74aa63190`) - ❌

source-mysql test report (commit `3f5fb03bd0`) - ✅

source-mysql-strict-encrypt test report (commit `3f5fb03bd0`) - ❌

vercel bot commented Sep 19, 2023 •

edited

Loading

source-mysql test report (commit `5f520bed5c`) - ✅

source-mysql-strict-encrypt test report (commit `5f520bed5c`) - ❌

source-mysql-strict-encrypt test report (commit `bb6dbab4be`) - ✅

source-mysql test report (commit `bb6dbab4be`) - ✅