-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Source Shopify: Include socat binary in docker image #30560
Conversation
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 as this is just a test
cc @alafanechere - Peter is testing if in-container SOCAT is faster/cheaper than an external orchestrated SOCAT pod. If this works, he'll be reaching out to you to learn how to get socat included in the new base images you are building
source-shopify test report (commit
|
Step | Result |
---|---|
Connector package install | ✅ |
Build source-shopify docker image for platform linux/x86_64 | ✅ |
Unit tests | ✅ |
Acceptance tests | ✅ |
Code format checks | ✅ |
Validate airbyte-integrations/connectors/source-shopify/metadata.yaml | ✅ |
Connector version semver check | ✅ |
Connector version increment check | ✅ |
QA checks | ✅ |
☁️ View runs for commit in Dagger Cloud
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-shopify test
What
This is for
How
Build and publish source shopify to include socat in the docker image.
This will then be used in https://github.com/airbytehq/airbyte-platform-internal/pull/8870
🚨 User Impact 🚨
None from this PR alone (socat will be added to the image but won't be used until https://github.com/airbytehq/airbyte-platform-internal/pull/8870 is merged.)