Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Source Jira: add suggested streams, update doc, add skip for 404 error in issues properties stream #30585

Merged

Conversation

darynaishchenko
Copy link
Collaborator

@darynaishchenko darynaishchenko commented Sep 19, 2023

What

As part of certification - add suggested streams and update doc file, add skip for 404 error in issues properties stream

How

added suggested streams and updated doc file
Added skip for 404 error in issue properties stream(Issue does not exist or you do not have permission to see it)

@darynaishchenko darynaishchenko self-assigned this Sep 19, 2023
@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/jira labels Sep 19, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 19, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@vercel
Copy link

vercel bot commented Sep 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 20, 2023 10:12am

@github-actions
Copy link
Contributor

source-jira test report (commit 40e448c59c) - ❌

⏲️ Total pipeline duration: 01mn39s

Step Result
Connector package install
Build source-jira docker image for platform linux/x86_64
Unit tests
Integration tests
Acceptance tests
Code format checks
Validate airbyte-integrations/connectors/source-jira/metadata.yaml
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-jira test

@github-actions
Copy link
Contributor

source-jira test report (commit ae25828202) - ✅

⏲️ Total pipeline duration: 08mn58s

Step Result
Connector package install
Build source-jira docker image for platform linux/x86_64
Unit tests
Integration tests
Acceptance tests
Code format checks
Validate airbyte-integrations/connectors/source-jira/metadata.yaml
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-jira test

@darynaishchenko darynaishchenko marked this pull request as draft September 20, 2023 09:24
@github-actions
Copy link
Contributor

source-jira test report (commit 26bc0c47ee) - ❌

⏲️ Total pipeline duration: 09mn11s

Step Result
Connector package install
Build source-jira docker image for platform linux/x86_64
Unit tests
Integration tests
Acceptance tests
Code format checks
Validate airbyte-integrations/connectors/source-jira/metadata.yaml
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-jira test

@darynaishchenko darynaishchenko force-pushed the daryna/source-jira/remove-start-date-from-spec branch from 72a1cd9 to 141f806 Compare September 20, 2023 10:11
@darynaishchenko darynaishchenko changed the title ✨ Source Jira: remove start date from spec, add suggested streams, update doc ✨ Source Jira: add suggested streams, update doc, add skip for 404 error in issues properties stream Sep 20, 2023
@darynaishchenko darynaishchenko marked this pull request as ready for review September 20, 2023 10:15
@github-actions
Copy link
Contributor

source-jira test report (commit 141f8060d2) - ✅

⏲️ Total pipeline duration: 08mn42s

Step Result
Connector package install
Build source-jira docker image for platform linux/x86_64
Unit tests
Integration tests
Acceptance tests
Code format checks
Validate airbyte-integrations/connectors/source-jira/metadata.yaml
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-jira test

@darynaishchenko darynaishchenko merged commit 891e389 into master Sep 20, 2023
24 checks passed
@darynaishchenko darynaishchenko deleted the daryna/source-jira/remove-start-date-from-spec branch September 20, 2023 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/jira
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants