🐛 Destination DuckDB: Fix schema name handling #30600

aaronsteers · 2023-09-19T23:48:38Z

What

Describe what the change is solving
It helps to add screenshots if it affects the frontend.

How

Describe the solution

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user?

For connector PRs, use this section to explain which type of semantic versioning bump occurs as a result of the changes. Refer to our Semantic Versioning for Connectors guidelines for more information. Breaking changes to connectors must be documented by an Airbyte engineer (PR author, or reviewer for community PRs) by using the Breaking Change Release Playbook.

If there are breaking changes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Actions

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Community member? Grant edit access to maintainers (instructions)
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Connector version is set to 0.0.1
- Dockerfile has version 0.0.1
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- docs/integrations/<source or destination>/<name>.md including changelog with an entry for the initial version. See changelog example
- docs/integrations/README.md

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Unit & integration tests added

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:generateScaffolds then checking in your changes
Documentation which references the generator is updated as needed

vercel · 2023-09-19T23:48:43Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
airbyte-docs	⬜️ Ignored (Inspect)	Visit Preview		Sep 20, 2023 3:47pm

github-actions · 2023-09-19T23:49:10Z

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

PR name follows PR naming conventions
Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
Secrets in the connector's spec are annotated with airbyte_secret
All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

Check for hidden checklists in your PR description
Toggle the github label checklist-action-run on/off to re-run the checklist CI.

github-actions · 2023-09-20T02:20:27Z

destination-duckdb test report (commit `a360cb076a`) - ❌

⏲️ Total pipeline duration: 02mn07s

Step	Result
Connector package install	✅
Build destination-duckdb docker image for platform linux/x86_64	✅
Unit tests	✅
Integration tests	❌
Acceptance tests	✅
Code format checks	❌
Validate airbyte-integrations/connectors/destination-duckdb/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-duckdb test

github-actions · 2023-09-20T02:24:58Z

destination-duckdb test report (commit `ff9e6bfcaf`) - ❌

⏲️ Total pipeline duration: 02mn20s

Step	Result
Connector package install	✅
Build destination-duckdb docker image for platform linux/x86_64	✅
Unit tests	✅
Integration tests	❌
Acceptance tests	✅
Code format checks	❌
Validate airbyte-integrations/connectors/destination-duckdb/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-duckdb test

github-actions · 2023-09-20T02:48:18Z

destination-duckdb test report (commit `339c85dc27`) - ❌

⏲️ Total pipeline duration: 02mn02s

Step	Result
Connector package install	✅
Build destination-duckdb docker image for platform linux/x86_64	✅
Unit tests	✅
Integration tests	❌
Acceptance tests	✅
Code format checks	❌
Validate airbyte-integrations/connectors/destination-duckdb/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-duckdb test

github-actions · 2023-09-20T14:45:34Z

destination-duckdb test report (commit `b24580df69`) - ❌

⏲️ Total pipeline duration: 02mn58s

Step	Result
Connector package install	✅
Build destination-duckdb docker image for platform linux/x86_64	✅
Unit tests	✅
Integration tests	❌
Acceptance tests	✅
Code format checks	❌
Validate airbyte-integrations/connectors/destination-duckdb/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-duckdb test

github-actions · 2023-09-20T14:51:00Z

destination-duckdb test report (commit `0b85297078`) - ❌

⏲️ Total pipeline duration: 02mn56s

Step	Result
Connector package install	✅
Build destination-duckdb docker image for platform linux/x86_64	✅
Unit tests	✅
Integration tests	❌
Acceptance tests	✅
Code format checks	❌
Validate airbyte-integrations/connectors/destination-duckdb/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-duckdb test

github-actions · 2023-09-20T15:29:03Z

destination-duckdb test report (commit `c9f1945e1c`) - ❌

⏲️ Total pipeline duration: 01mn38s

Step	Result
Connector package install	✅
Build destination-duckdb docker image for platform linux/x86_64	✅
Unit tests	✅
Integration tests	✅
Acceptance tests	✅
Code format checks	❌
Validate airbyte-integrations/connectors/destination-duckdb/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-duckdb test

github-actions · 2023-09-20T15:50:21Z

destination-duckdb test report (commit `ffd891f3d7`) - ❌

⏲️ Total pipeline duration: 02mn22s

Step	Result
Connector package install	✅
Build destination-duckdb docker image for platform linux/x86_64	✅
Unit tests	✅
Integration tests	✅
Acceptance tests	✅
Code format checks	❌
Validate airbyte-integrations/connectors/destination-duckdb/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-duckdb test

aaronsteers · 2023-09-20T15:51:31Z

This is ready to go. Since the MotherDuck launch and funding just got announced, I'm planning to go ahead and merge as a high urgency, low risk change.

Tests are passing locally and in CI. We had to pull in a bunch of formatting changes because format rules are more stringent today than yesterday.

fix: add missing schema name handling

5a133c9

octavia-squidington-iii added area/connectors Connector related issues connectors/destination/duckdb labels Sep 19, 2023

aaronsteers added 2 commits September 19, 2023 16:55

chore: add schema_name to integration tests

402a1a4

chore: version bump to v0.2.2

83c2b1d

octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Sep 20, 2023

aaronsteers changed the title ~~Destination DuckDB: Fix schema name handling~~ 🐛 Destination DuckDB: Fix schema name handling Sep 20, 2023

vercel bot deployed to Preview September 20, 2023 00:03 View deployment

chore: rename version from 0.2.2 to 0.2.1

a360cb0

vercel bot deployed to Preview September 20, 2023 00:11 View deployment

aaronsteers marked this pull request as ready for review September 20, 2023 02:16

Merge branch 'master' into destination-duckdb/fix/schema-name-config

ff9e6bf

vercel bot deployed to Preview September 20, 2023 02:20 View deployment

docs: note DuckDB version in changelog

339c85d

vercel bot deployed to Preview September 20, 2023 02:45 View deployment

docs: fix typo

b24580d

vercel bot deployed to Preview September 20, 2023 14:41 View deployment

Merge branch 'master' into destination-duckdb/fix/schema-name-config

0b85297

vercel bot deployed to Preview September 20, 2023 14:47 View deployment

chore: debug tests, add unit test, improve schema name handling

c9f1945

aaronsteers added 2 commits September 20, 2023 15:37

chore: fix incorrect black vs code extension ID

a95c78a

chore: improve devcontainer default settings

0b17d2b

chore: format python files with black

ffd891f

aaronsteers merged commit f2a1841 into master Sep 20, 2023
15 checks passed

aaronsteers deleted the destination-duckdb/fix/schema-name-config branch September 20, 2023 15:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🐛 Destination DuckDB: Fix schema name handling #30600

🐛 Destination DuckDB: Fix schema name handling #30600

aaronsteers commented Sep 19, 2023

vercel bot commented Sep 19, 2023 •

edited

Loading

github-actions bot commented Sep 19, 2023 •

edited by aaronsteers

Loading

github-actions bot commented Sep 20, 2023

github-actions bot commented Sep 20, 2023

github-actions bot commented Sep 20, 2023

github-actions bot commented Sep 20, 2023

github-actions bot commented Sep 20, 2023

github-actions bot commented Sep 20, 2023

github-actions bot commented Sep 20, 2023

aaronsteers commented Sep 20, 2023

🐛 Destination DuckDB: Fix schema name handling #30600

🐛 Destination DuckDB: Fix schema name handling #30600

Conversation

aaronsteers commented Sep 19, 2023

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Actions

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

vercel bot commented Sep 19, 2023 • edited Loading

github-actions bot commented Sep 19, 2023 • edited by aaronsteers Loading

Before Merging a Connector Pull Request

github-actions bot commented Sep 20, 2023

destination-duckdb test report (commit a360cb076a) - ❌

github-actions bot commented Sep 20, 2023

destination-duckdb test report (commit ff9e6bfcaf) - ❌

github-actions bot commented Sep 20, 2023

destination-duckdb test report (commit 339c85dc27) - ❌

github-actions bot commented Sep 20, 2023

destination-duckdb test report (commit b24580df69) - ❌

github-actions bot commented Sep 20, 2023

destination-duckdb test report (commit 0b85297078) - ❌

github-actions bot commented Sep 20, 2023

destination-duckdb test report (commit c9f1945e1c) - ❌

github-actions bot commented Sep 20, 2023

destination-duckdb test report (commit ffd891f3d7) - ❌

aaronsteers commented Sep 20, 2023

vercel bot commented Sep 19, 2023 •

edited

Loading

github-actions bot commented Sep 19, 2023 •

edited by aaronsteers

Loading

destination-duckdb test report (commit `a360cb076a`) - ❌

destination-duckdb test report (commit `ff9e6bfcaf`) - ❌

destination-duckdb test report (commit `339c85dc27`) - ❌

destination-duckdb test report (commit `b24580df69`) - ❌

destination-duckdb test report (commit `0b85297078`) - ❌

destination-duckdb test report (commit `c9f1945e1c`) - ❌

destination-duckdb test report (commit `ffd891f3d7`) - ❌