-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pinecone destination: Add namespace setting #30789
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
destination-pinecone test report (commit
|
Step | Result |
---|---|
Connector package install | ✅ |
Build destination-pinecone docker image for platform linux/x86_64 | ✅ |
Unit tests | ✅ |
Integration tests | ✅ |
Acceptance tests | ✅ |
Code format checks | ✅ |
Validate airbyte-integrations/connectors/destination-pinecone/metadata.yaml | ✅ |
Connector version semver check | ✅ |
Connector version increment check | ✅ |
QA checks | ✅ |
☁️ View runs for commit in Dagger Cloud
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=destination-pinecone test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM, but one question before I approve:
Did we consider using airbyte's native namespaces
for this feature or is this materially different than what we're using it for in DB/DW destinations? Upon first look, it seems similar to me.
Would it be possible to, instead of adding a config var, use the connection's configured namespace as the pinecone namespace?
@@ -24,6 +24,25 @@ | |||
"title": "Index", | |||
"description": "Pinecone index in your project to load data into", | |||
"type": "string" | |||
}, | |||
"namespace": { | |||
"title": "NamespaceModel", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this title show up anywhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it's just internal.
@pedroslopez Good catch with the namespace, I think you are right that the concepts are similar enough. My mental model had them closely wired with sql-to-sql replication, but I guess this is close enough to be confusing if it wouldn't use these namespaces, so I will rewrite, especially as the basic use case of specifying a state namespace can be used just fine. |
Replaced by #31373 |
What
Fixes #30574
By adding a new optional "namespace" field:
If set, all records are indexed into this namespace. It is not available on starter pods (check is validating that)
The config is structured via a separate object for the namespace setting to allow extensions of different "namespace modes" later on if required using a oneOf without breaking existing configurations. (e.g. reading the namespace from the stream name or from a field in each record)