Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pinecone destination: Add namespace setting #30789

Closed
wants to merge 2 commits into from

Conversation

flash1293
Copy link
Contributor

What

Fixes #30574

By adding a new optional "namespace" field:

Screenshot 2023-09-27 at 12 48 08

If set, all records are indexed into this namespace. It is not available on starter pods (check is validating that)

The config is structured via a separate object for the namespace setting to allow extensions of different "namespace modes" later on if required using a oneOf without breaking existing configurations. (e.g. reading the namespace from the stream name or from a field in each record)

@vercel
Copy link

vercel bot commented Sep 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 27, 2023 10:55am

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Sep 27, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 27, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@airbyte-oss-build-runner
Copy link
Collaborator

destination-pinecone test report (commit 585f12e67b) - ✅

⏲️ Total pipeline duration: 02mn45s

Step Result
Connector package install
Build destination-pinecone docker image for platform linux/x86_64
Unit tests
Integration tests
Acceptance tests
Code format checks
Validate airbyte-integrations/connectors/destination-pinecone/metadata.yaml
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-pinecone test

Copy link
Contributor

@pedroslopez pedroslopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM, but one question before I approve:

Did we consider using airbyte's native namespaces for this feature or is this materially different than what we're using it for in DB/DW destinations? Upon first look, it seems similar to me.

Would it be possible to, instead of adding a config var, use the connection's configured namespace as the pinecone namespace?

@@ -24,6 +24,25 @@
"title": "Index",
"description": "Pinecone index in your project to load data into",
"type": "string"
},
"namespace": {
"title": "NamespaceModel",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this title show up anywhere?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it's just internal.

@flash1293
Copy link
Contributor Author

@pedroslopez Good catch with the namespace, I think you are right that the concepts are similar enough.

My mental model had them closely wired with sql-to-sql replication, but I guess this is close enough to be confusing if it wouldn't use these namespaces, so I will rewrite, especially as the basic use case of specifying a state namespace can be used just fine.

@flash1293
Copy link
Contributor Author

Replaced by #31373

@flash1293 flash1293 closed this Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/destination/pinecone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pinecone destination: Allow namespace configuration
4 participants