🐛 Source Jira: fix incorrect types in issue schema #31080

archangelic · 2023-10-04T21:31:50Z

What

in the issue schema, the properties aggregatetimeoriginalestimate and timeoriginalestimate should be strings. This corrects those types

How

Describe the solution

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user?

For connector PRs, use this section to explain which type of semantic versioning bump occurs as a result of the changes. Refer to our Semantic Versioning for Connectors guidelines for more information. Breaking changes to connectors must be documented by an Airbyte engineer (PR author, or reviewer for community PRs) by using the Breaking Change Release Playbook.

If there are breaking changes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Actions

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Unit & integration tests added

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.

vercel · 2023-10-04T21:31:55Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
airbyte-docs	⬜️ Ignored (Inspect)	Visit Preview		Oct 12, 2023 9:20pm

github-actions · 2023-10-04T21:32:17Z

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

PR name follows PR naming conventions
Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
Secrets in the connector's spec are annotated with airbyte_secret
All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

Check for hidden checklists in your PR description
Toggle the github label checklist-action-run on/off to re-run the checklist CI.

airbyte-oss-build-runner · 2023-10-04T21:35:26Z

source-jira test report (commit `0cdfb34414`) - ❌

⏲️ Total pipeline duration: 01mn01s

Step	Result
Connector package install	✅
Build source-jira docker image for platform(s) linux/x86_64	✅
Unit tests	❌
Code format checks	✅
Validate metadata for source-jira	✅
Connector version semver check	✅
Connector version increment check	❌
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-jira test

airbyte-oss-build-runner · 2023-10-09T21:25:16Z

source-jira test report (commit `b86bc47d65`) - ❌

⏲️ Total pipeline duration: 10mn47s

Step	Result
Connector package install	✅
Build source-jira docker image for platform(s) linux/x86_64	✅
Unit tests	✅
Integration tests	✅
Acceptance tests	❌
Code format checks	✅
Validate metadata for source-jira	✅
Connector version semver check	✅
Connector version increment check	❌
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-jira test

airbyte-oss-build-runner · 2023-10-09T23:27:03Z

source-jira test report (commit `ef021826ec`) - ❌

⏲️ Total pipeline duration: 10mn01s

Step	Result
Connector package install	✅
Build source-jira docker image for platform(s) linux/x86_64	✅
Unit tests	✅
Integration tests	✅
Acceptance tests	✅
Code format checks	✅
Validate metadata for source-jira	✅
Connector version semver check	✅
Connector version increment check	❌
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-jira test

airbyte-oss-build-runner · 2023-10-09T23:51:33Z

source-jira test report (commit `a999ca681c`) - ❌

⏲️ Total pipeline duration: 09mn49s

Step	Result
Connector package install	✅
Build source-jira docker image for platform(s) linux/x86_64	✅
Unit tests	✅
Integration tests	✅
Acceptance tests	✅
Code format checks	✅
Validate metadata for source-jira	❌
Connector version semver check	✅
Connector version increment check	✅
QA checks	❌

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-jira test

airbyte-oss-build-runner · 2023-10-10T00:02:15Z

source-jira test report (commit `76030c7225`) - ❌

⏲️ Total pipeline duration: 05mn32s

Step	Result
Connector package install	✅
Build source-jira docker image for platform(s) linux/x86_64	✅
Unit tests	✅
Integration tests	✅
Acceptance tests	✅
Code format checks	✅
Validate metadata for source-jira	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	❌

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-jira test

airbyte-oss-build-runner · 2023-10-10T16:12:52Z

source-jira test report (commit `f4ab999973`) - ✅

⏲️ Total pipeline duration: 10mn14s

Step	Result
Connector package install	✅
Build source-jira docker image for platform(s) linux/x86_64	✅
Unit tests	✅
Integration tests	✅
Acceptance tests	✅
Code format checks	✅
Validate metadata for source-jira	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-jira test

marcosmarxm

Right now all expected records have null values.
Is there an explicit documentation saying these fields are string type?
Is it possible to add some data into Airbyte integration account to validate the change?

airbyte-oss-build-runner · 2023-10-12T21:11:42Z

source-jira test report (commit `02bab1d91c`) - ❌

⏲️ Total pipeline duration: 09mn47s

Step	Result
Build source-jira docker image for platform(s) linux/x86_64	✅
Unit tests	✅
Integration tests	✅
Acceptance tests	❌
Code format checks	✅
Validate metadata for source-jira	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-jira test

airbyte-oss-build-runner · 2023-10-12T21:32:38Z

source-jira test report (commit `2b6ad7503b`) - ✅

⏲️ Total pipeline duration: 09mn43s

Step	Result
Build source-jira docker image for platform(s) linux/x86_64	✅
Unit tests	✅
Integration tests	✅
Acceptance tests	✅
Code format checks	✅
Validate metadata for source-jira	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-jira test

added data and fixed expected records

archangelic · 2023-10-13T16:08:47Z

Solved in #31385

update schema

0cdfb34

octavia-squidington-iii added area/connectors Connector related issues connectors/source/jira labels Oct 4, 2023

Merge remote-tracking branch 'origin' into mal/jira-schema-fix

b86bc47

vercel bot deployed to Preview October 9, 2023 21:13 View deployment

update expected records

ef02182

iterate version

a999ca6

octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Oct 9, 2023

vercel bot deployed to Preview October 9, 2023 23:42 View deployment

add upgradeDeadline

76030c7

archangelic added the gl label Oct 9, 2023

fix migrations

f4ab999

vercel bot deployed to Preview October 10, 2023 16:02 View deployment

archangelic removed the gl label Oct 10, 2023

archangelic added the checklist-action-run label Oct 10, 2023

sajarin approved these changes Oct 10, 2023

View reviewed changes

marcosmarxm previously requested changes Oct 10, 2023

View reviewed changes

archangelic added 3 commits October 12, 2023 13:51

update expected_records

97e9836

correct expected_records

8925813

Merge branch 'master' into mal/jira-schema-fix

02bab1d

vercel bot deployed to Preview October 12, 2023 21:00 View deployment

update expected records

2b6ad75

archangelic added gl gl-review labels Oct 12, 2023

archangelic closed this Oct 13, 2023

archangelic deleted the mal/jira-schema-fix branch October 19, 2023 22:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🐛 Source Jira: fix incorrect types in issue schema #31080

🐛 Source Jira: fix incorrect types in issue schema #31080

archangelic commented Oct 4, 2023 •

edited

Loading

vercel bot commented Oct 4, 2023 •

edited

Loading

github-actions bot commented Oct 4, 2023 •

edited by archangelic

Loading

airbyte-oss-build-runner commented Oct 4, 2023

airbyte-oss-build-runner commented Oct 9, 2023

airbyte-oss-build-runner commented Oct 9, 2023

airbyte-oss-build-runner commented Oct 9, 2023

airbyte-oss-build-runner commented Oct 10, 2023

airbyte-oss-build-runner commented Oct 10, 2023

marcosmarxm left a comment

airbyte-oss-build-runner commented Oct 12, 2023

airbyte-oss-build-runner commented Oct 12, 2023

archangelic commented Oct 13, 2023

🐛 Source Jira: fix incorrect types in issue schema #31080

🐛 Source Jira: fix incorrect types in issue schema #31080

Conversation

archangelic commented Oct 4, 2023 • edited Loading

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Actions

Community member or Airbyter

Airbyter

vercel bot commented Oct 4, 2023 • edited Loading

github-actions bot commented Oct 4, 2023 • edited by archangelic Loading

Before Merging a Connector Pull Request

airbyte-oss-build-runner commented Oct 4, 2023

source-jira test report (commit 0cdfb34414) - ❌

airbyte-oss-build-runner commented Oct 9, 2023

source-jira test report (commit b86bc47d65) - ❌

airbyte-oss-build-runner commented Oct 9, 2023

source-jira test report (commit ef021826ec) - ❌

airbyte-oss-build-runner commented Oct 9, 2023

source-jira test report (commit a999ca681c) - ❌

airbyte-oss-build-runner commented Oct 10, 2023

source-jira test report (commit 76030c7225) - ❌

airbyte-oss-build-runner commented Oct 10, 2023

source-jira test report (commit f4ab999973) - ✅

marcosmarxm left a comment

Choose a reason for hiding this comment

airbyte-oss-build-runner commented Oct 12, 2023

source-jira test report (commit 02bab1d91c) - ❌

airbyte-oss-build-runner commented Oct 12, 2023

source-jira test report (commit 2b6ad7503b) - ✅

archangelic commented Oct 13, 2023

archangelic commented Oct 4, 2023 •

edited

Loading

vercel bot commented Oct 4, 2023 •

edited

Loading

github-actions bot commented Oct 4, 2023 •

edited by archangelic

Loading

source-jira test report (commit `0cdfb34414`) - ❌

source-jira test report (commit `b86bc47d65`) - ❌

source-jira test report (commit `ef021826ec`) - ❌

source-jira test report (commit `a999ca681c`) - ❌

source-jira test report (commit `76030c7225`) - ❌

source-jira test report (commit `f4ab999973`) - ✅

source-jira test report (commit `02bab1d91c`) - ❌

source-jira test report (commit `2b6ad7503b`) - ✅