Source GCS: Migrated to file based CDK #31212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
octavia-squidington-iii
added
area/connectors
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
octavia-squidington-iii
added
the
area/documentation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
tolik0
reviewed
Oct 16, 2023
tolik0
reviewed
Oct 16, 2023
tolik0
approved these changes
Oct 16, 2023
lazebnyi
requested review from
clnoll
and removed request for
davydov-d,
bazarnov and
roman-yermilov-gl
clnoll
requested changes
Oct 19, 2023
There was a problem hiding this comment.
Nice @lazebnyi! Just one minor comment & question in the code.
A couple of requests for tests:
- Since the file-based CDK supports incremental syncs, I assume we'll start supporting incremental for GCS (unless we're planning to turn it on later and hide it in the UI somehow until then). Can you add some CATs covering incremental? You can look at the S3 tests for examples.
- Have the configs been migrated to the new format yet? I think we'll want CATs that run the new code with both the old and new formats.
airbyte-integrations/connectors/source-gcs/integration_tests/configured_catalog.json
Show resolved
Hide resolved
airbyte-integrations/connectors/source-gcs/integration_tests/spec.json
Outdated
Show resolved
Hide resolved
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
| Step | Result |
|---|---|
| Build source-gcs docker image for platform(s) linux/amd64 | ✅ |
| Unit tests | ✅ |
| Acceptance tests | ✅ |
| Code format checks | ✅ |
| Validate metadata for source-gcs | ✅ |
| Connector version semver check | ✅ |
| Connector version increment check | ✅ |
| QA checks | ✅ |
☁️ View runs for commit in Dagger Cloud
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-gcs test
bazarnov
approved these changes
Oct 24, 2023
clnoll
reviewed
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixed #29831
Need to migrate connector into a scalable and easy-to-manage connector.
How
Migrated connector to file based CDK
🚨 User Impact 🚨
No
Pre-merge Actions
Updating a connector
Community member or Airbyter
NOTE: UNIT TESTS IN PREGRESS
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.