-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix connector harness performance ci run #31304
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
/connector-performance
|
/connector-performance connector="source/postgres" Note: The following
|
/connector-performance connector="connectors/source-postgres" |
@@ -4,7 +4,13 @@ on: | |||
inputs: | |||
connector: | |||
description: "Airbyte Connector" | |||
type: choice |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Can this replace the code down the file that filters for supported connectors - the big ugly if
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we still need that because we still want to trigger it from comment command
/connector-performance connector="connectors/source-postgres" dataset="1m" |
Co-authored-by: xiaohansong <[email protected]>
What
#29334 Fix connector harness performance ci run
Run result:
https://github.com/airbytehq/airbyte/actions/runs/6501560655/job/17659126699 (Postgres)
https://github.com/airbytehq/airbyte/actions/runs/6498858797 (MySQL)
How
A few bugs fixed:
pipx ensurepath
cannot update path; thus /root/.local/bin has to be added manuallya few improvements:
Recommended reading order
x.java
y.python
🚨 User Impact 🚨
Are there any breaking changes? What is the end result perceived by the user?
For connector PRs, use this section to explain which type of semantic versioning bump occurs as a result of the changes. Refer to our Semantic Versioning for Connectors guidelines for more information. Breaking changes to connectors must be documented by an Airbyte engineer (PR author, or reviewer for community PRs) by using the Breaking Change Release Playbook.
If there are breaking changes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.
Pre-merge Actions
Expand the relevant checklist and delete the others.
New Connector
Community member or Airbyter
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.0.0.1
Dockerfile
has version0.0.1
README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog with an entry for the initial version. See changelog exampledocs/integrations/README.md
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
Updating a connector
Community member or Airbyter
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
Connector Generator
-scaffold
in their name) have been updated with the latest scaffold by running./gradlew :airbyte-integrations:connector-templates:generator:generateScaffolds
then checking in your changesUpdating the Python CDK
Airbyter
Before merging:
--use-local-cdk --name=source-<connector>
as optionsairbyte-ci connectors --use-local-cdk --name=source-<connector> test
After merging: