Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gradle: set user timezone to UTC in all tests #31305

Merged
merged 1 commit into from
Oct 12, 2023
Merged

gradle: set user timezone to UTC in all tests #31305

merged 1 commit into from
Oct 12, 2023

Conversation

postamar
Copy link
Contributor

Fixes #31060.

@vercel
Copy link

vercel bot commented Oct 11, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Oct 11, 2023 6:47pm

@octavia-squidington-iii octavia-squidington-iii added the CDK Connector Development Kit label Oct 11, 2023
@postamar
Copy link
Contributor Author

postamar commented Oct 11, 2023 •
edited
Loading

Testing on:

edit: all green

@postamar postamar marked this pull request as ready for review October 11, 2023 21:09
@postamar postamar requested review from jdpgrailsdev and a team October 11, 2023 21:10
evantahler
evantahler approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@evantahler evantahler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no idea what the side effects will be... but I love it.

jdpgrailsdev
jdpgrailsdev approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@jdpgrailsdev jdpgrailsdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jdpgrailsdev
Copy link
Contributor

no idea what the side effects will be... but I love it.

This ensures that Java interprets all timestamps as UTC when running the unit tests. The goal is to make the tests deterministic when using timestamps to avoid it passing on one machine, but failing on another because the timezones in use are different. It will not impact the code at runtime, though this is something to consider setting in general to make it easy for our customers to understand how we treat timestamps.

@postamar postamar merged commit 29b4118 into master Oct 12, 2023
@postamar postamar deleted the postamar/use-utc-tz-in-tests branch October 12, 2023 14:01
ariesgun pushed a commit to ariesgun/airbyte that referenced this pull request Oct 23, 2023
@postamar @ariesgun
gradle: set user timezone to UTC in all tests (airbytehq#31305)
ed753d8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdpgrailsdev jdpgrailsdev jdpgrailsdev approved these changes

@evantahler evantahler evantahler approved these changes

Assignees
No one assigned
Labels
CDK Connector Development Kit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set user timezone for all Java tests
4 participants
@postamar @jdpgrailsdev @evantahler @octavia-squidington-iii