airbyte-ci: Add basic segment tracking #31354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
bnchrch
force-pushed
the
bnchrch/airbyte-ci/add-segment
branch
from
760a05a to
673e1cf
Compare
evantahler
reviewed
Oct 16, 2023
|
|
||
| import segment.analytics as analytics | ||
|
|
||
| analytics.write_key = "G6G7whgro81g9xM00kN2buclGKvcOjFd" |
There was a problem hiding this comment.
We cool checking this in?
There was a problem hiding this comment.
I imagine so. We already have checked in the write key for octavia cli. I dont see the difference here.
Also not too disimilar to how sentry/segment FE libraries work
| top_level_command = ctx.command_path | ||
| full_cmd = " ".join(sys.argv) | ||
|
|
||
| sys_user_name = getpass.getuser() |
There was a problem hiding this comment.
Any PII worries here? I guess this is an internal tool for now
There was a problem hiding this comment.
Good callout. @evantahler Ill go ahead and hash their machine info
Comment on lines
12
to
13
| def _is_airbyte_user(): | ||
| return os.getenv("AIRBYTE_ROLE") == "airbyter" |
evantahler
approved these changes
Oct 16, 2023
evantahler
approved these changes
Oct 17, 2023
ariesgun
pushed a commit
to ariesgun/airbyte
that referenced
this pull request
Oct 23, 2023
Co-authored-by: bnchrch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We dont know what amount of usage
airbyte-ciis receivingSolution
Add basic segment tracking
closes #31255