Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛Source Klaviyo: add availability strategy #31379

Merged
merged 5 commits into from
Oct 16, 2023

Conversation

askarpets
Copy link
Contributor

@askarpets askarpets commented Oct 13, 2023

What

Enable AvailabilityStrategy for both KlaviyoStreamLatest and KlaviyoStreamV1
#22258

How

For the KlaviyoStreamV1, removed override of availability_strategy method, which previously returned None, so now it uses HttpAvailabilityStrategy.
For the KlaviyoStreamLatest, implemented KlaviyoAvailabilityStrategyLatest, which extends the list of unavailable_status_codes with code of 401.

Recommended reading order

  1. availability_strategy.py
  2. streams.py

🚨 User Impact 🚨

No breaking changes

Pre-merge Actions

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Unit & integration tests added

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.

@vercel
Copy link

vercel bot commented Oct 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Oct 16, 2023 11:38am

@github-actions
Copy link
Contributor

github-actions bot commented Oct 13, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@airbyte-oss-build-runner
Copy link
Collaborator

source-klaviyo test report (commit d0e276ab39) - ❌

⏲️ Total pipeline duration: 03mn18s

Step Result
Build source-klaviyo docker image for platform(s) linux/x86_64
Unit tests
Acceptance tests
Code format checks
Validate metadata for source-klaviyo
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-klaviyo test

@airbyte-oss-build-runner
Copy link
Collaborator

source-klaviyo test report (commit ba2240e12e) - ❌

⏲️ Total pipeline duration: 03mn34s

Step Result
Build source-klaviyo docker image for platform(s) linux/x86_64
Unit tests
Acceptance tests
Code format checks
Validate metadata for source-klaviyo
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-klaviyo test

@airbyte-oss-build-runner
Copy link
Collaborator

source-klaviyo test report (commit b6bec8ed7d) - ❌

⏲️ Total pipeline duration: 02mn46s

Step Result
Build source-klaviyo docker image for platform(s) linux/x86_64
Unit tests
Acceptance tests
Code format checks
Validate metadata for source-klaviyo
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-klaviyo test

@airbyte-oss-build-runner
Copy link
Collaborator

source-klaviyo test report (commit b6bec8ed7d) - ❌

⏲️ Total pipeline duration: 03mn20s

Step Result
Build source-klaviyo docker image for platform(s) linux/x86_64
Unit tests
Acceptance tests
Code format checks
Validate metadata for source-klaviyo
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-klaviyo test

@airbyte-oss-build-runner
Copy link
Collaborator

source-klaviyo test report (commit e024801cbd) - ❌

⏲️ Total pipeline duration: 01mn48s

Step Result
Build source-klaviyo docker image for platform(s) linux/x86_64
Unit tests
Acceptance tests
Code format checks
Validate metadata for source-klaviyo
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-klaviyo test

@airbyte-oss-build-runner
Copy link
Collaborator

source-klaviyo test report (commit 098b659c5b) - ✅

⏲️ Total pipeline duration: 02mn38s

Step Result
Build source-klaviyo docker image for platform(s) linux/x86_64
Unit tests
Acceptance tests
Code format checks
Validate metadata for source-klaviyo
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-klaviyo test

Copy link
Collaborator

@bazarnov bazarnov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please bind the issues and PR together.

@askarpets askarpets linked an issue Oct 16, 2023 that may be closed by this pull request
@askarpets askarpets requested a review from lazebnyi October 16, 2023 12:13
@askarpets askarpets merged commit 2f247cf into master Oct 16, 2023
17 checks passed
@askarpets askarpets deleted the 22258-source-klaviyo-availability-strategy branch October 16, 2023 12:44
ariesgun pushed a commit to ariesgun/airbyte that referenced this pull request Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/klaviyo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Source source-klaviyo: implement AvailabilityStrategy
4 participants