Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Source S3: Add region to config #31701

Closed
wants to merge 1 commit into from

Conversation

hawkaa
Copy link
Contributor

@hawkaa hawkaa commented Oct 23, 2023

Fixes #20860

What

Adds support for specifying region as a part of specifying the S3 source connector.

Screenshot 2023-10-23 at 12 36 04

How

Adds a new config item and passes it to the S3 client.

Recommended reading order

🚨 User Impact 🚨

No breaking changes. The new field is optional

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Unit & integration tests added

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.

@vercel
Copy link

vercel bot commented Oct 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 2, 2024 6:06am

@CLAassistant
Copy link

CLAassistant commented Oct 23, 2023

CLA assistant check
All committers have signed the CLA.

@octavia-squidington-iii octavia-squidington-iii added the area/connectors Connector related issues label Oct 23, 2023
@github-actions
Copy link
Contributor

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@hawkaa hawkaa changed the title Add region to S3 Source Source S3: Add region to config Oct 23, 2023
@hawkaa hawkaa changed the title Source S3: Add region to config ✨ Source S3: Add region to config Oct 23, 2023
@hawkaa hawkaa force-pushed the hakon/s3-region branch 2 times, most recently from 3feabac to 723cab3 Compare October 23, 2023 10:55
@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Oct 23, 2023
@marcosmarxm
Copy link
Member

Thanks for the contribution @hawkaa sorry the lack of update. Are you still interested in continuing the contribution?

@hawkaa
Copy link
Contributor Author

hawkaa commented Nov 23, 2023

Thanks for the contribution @hawkaa sorry the lack of update. Are you still interested in continuing the contribution?

Yeah, would love to! What's next? I assume that I need to rebase the changes at the very least?

@marcosmarxm
Copy link
Member

Thanks for the contribution @hawkaa sorry the lack of update. Are you still interested in continuing the contribution?

Yeah, would love to! What's next? I assume that I need to rebase the changes at the very least?

Yes please.

@hawkaa
Copy link
Contributor Author

hawkaa commented Nov 28, 2023

Thanks for the contribution @hawkaa sorry the lack of update. Are you still interested in continuing the contribution?

Yeah, would love to! What's next? I assume that I need to rebase the changes at the very least?

Yes please.

Done!

@tolik0
Copy link
Contributor

tolik0 commented Feb 1, 2024

@hawkaa, Could you please update your branch to the latest version? It would be best if you also populated the AWS region for the IAM client.

@hawkaa
Copy link
Contributor Author

hawkaa commented Feb 2, 2024

@hawkaa, Could you please update your branch to the latest version? It would be best if you also populated the AWS region for the IAM client.

Done!

@tolik0
Copy link
Contributor

tolik0 commented Feb 6, 2024

@hawkaa The PR with your changes is merged. Thank you for your contribution!

@tolik0 tolik0 closed this Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Enable to choose non-AWS regions in S3 Connector
6 participants