-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Source S3: Add region
to config
#31701
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
region
to configregion
to config
3feabac
to
723cab3
Compare
Thanks for the contribution @hawkaa sorry the lack of update. Are you still interested in continuing the contribution? |
Yeah, would love to! What's next? I assume that I need to rebase the changes at the very least? |
Yes please. |
723cab3
to
65edb12
Compare
123da38
to
bb91b32
Compare
Done! |
@hawkaa, Could you please update your branch to the latest version? It would be best if you also populated the AWS region for the IAM client. |
bb91b32
to
634f4b6
Compare
634f4b6
to
a984afa
Compare
a984afa
to
549bdbb
Compare
Done! |
Fixes #20860
What
Adds support for specifying region as a part of specifying the S3 source connector.
How
Adds a new config item and passes it to the S3 client.
Recommended reading order
🚨 User Impact 🚨
No breaking changes. The new field is optional
Updating a connector
Community member or Airbyter
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.