-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨Source Klaviyo: make start_date optional #31710
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
source-klaviyo test report (commit
|
Step | Result |
---|---|
Build source-klaviyo docker image for platform(s) linux/amd64 | ✅ |
Unit tests | ✅ |
Acceptance tests | ✅ |
Check our base image is used | ✅ |
Code format checks | ❌ |
Validate metadata for source-klaviyo | ✅ |
Connector version semver check | ✅ |
Connector version increment check | ✅ |
QA checks | ❌ |
☁️ View runs for commit in Dagger Cloud
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-klaviyo test
…al' into source=klaviyo-start-date-optional
source-klaviyo test report (commit
|
Step | Result |
---|---|
Build source-klaviyo docker image for platform(s) linux/amd64 | ✅ |
Unit tests | ✅ |
Acceptance tests | ✅ |
Check our base image is used | ✅ |
Code format checks | ❌ |
Validate metadata for source-klaviyo | ✅ |
Connector version semver check | ✅ |
Connector version increment check | ✅ |
QA checks | ✅ |
☁️ View runs for commit in Dagger Cloud
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-klaviyo test
source-klaviyo test report (commit
|
Step | Result |
---|---|
Build source-klaviyo docker image for platform(s) linux/amd64 | ✅ |
Unit tests | ✅ |
Acceptance tests | ✅ |
Check our base image is used | ✅ |
Code format checks | ✅ |
Validate metadata for source-klaviyo | ✅ |
Connector version semver check | ✅ |
Connector version increment check | ✅ |
QA checks | ✅ |
☁️ View runs for commit in Dagger Cloud
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-klaviyo test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's add a parametrized unit test covering all these changes please
source-klaviyo test report (commit
|
Step | Result |
---|---|
Build source-klaviyo docker image for platform(s) linux/amd64 | ✅ |
Unit tests | ✅ |
Acceptance tests | ✅ |
Check our base image is used | ✅ |
Code format checks | ✅ |
Validate metadata for source-klaviyo | ✅ |
Connector version semver check | ✅ |
Connector version increment check | ✅ |
QA checks | ✅ |
☁️ View runs for commit in Dagger Cloud
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-klaviyo test
What
start_date
config parameter optionalHow
Mark the field as optional in the
spec.json
file and alignstreams.py
Recommended reading order
spec.json
source.py
streams.py
🚨 User Impact 🚨
No breaking changes
Pre-merge Actions
Updating a connector
Community member or Airbyter
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.