✨ Source Mailchimp: Add optional start_date to config #32852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stamp_without_timezone (#32595)
…fic_type` field to AdGroups stream (#32747)
… ad accounts during `check` (#32731)
… expected records, migrate base image (#32718) Co-authored-by: pnilan <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
octavia-squidington-iii
added
area/connectors
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
octavia-squidington-iii
added
the
area/documentation
…bytehq/airbyte into christo/mailchimp-start-date
lazebnyi
requested changes
Dec 20, 2023
Comment on lines
154
to
159
| if start_date_parsed and state_date_parsed: | ||
| return max(start_date_parsed, state_date_parsed) | ||
| elif state_date_parsed or start_date_parsed: | ||
| return state_date_parsed or start_date_parsed | ||
| else: | ||
| return None |
There was a problem hiding this comment.
Suggested change
| if start_date_parsed and state_date_parsed: | |
| return max(start_date_parsed, state_date_parsed) | |
| elif state_date_parsed or start_date_parsed: | |
| return state_date_parsed or start_date_parsed | |
| else: | |
| return None | |
| # Return the maximum of the two dates if both are present, otherwise return whichever is present, or None | |
| if start_date_parsed or state_date_parsed: | |
| return max(filter(None, [start_date_parsed, state_date_parsed]), default=None) |
| @@ -157,7 +181,11 @@ def stream_slices(self, stream_state: Mapping[str, Any] = None, **kwargs) -> Ite | |||
| stream_state = stream_state or {} | |||
| parent = Lists(authenticator=self.authenticator).read_records(sync_mode=SyncMode.full_refresh) | |||
| for slice in parent: | |||
| yield {"list_id": slice["id"]} | |||
| slice_ = {"list_id": slice["id"]} | |||
There was a problem hiding this comment.
I believe we can rename slice to parent_record and slice_ to slice
There was a problem hiding this comment.
Good call, updated
Comment on lines
504
to
505
| if filter_date is None or record_cursor_value >= filter_date: | ||
| yield record |
There was a problem hiding this comment.
this is can be separate filtration function
check Hubspot connector as example
There was a problem hiding this comment.
Thanks for the pointer 👍 A separate method, filter_old_records, is now declared in the base MailchimpIncrementalStream class and invoked by streams which do not support the server-side filter.
jatinyadav-cc
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Feb 26, 2024
jatinyadav-cc
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adds an optional
start_dateto Source Mailchimp's config, to resolve customer request in #20814How
start_dateis provided by a user via config, incremental streams will compare it against the value found in the current stream slice's state, to determine which to use as a filter in the query params. If only one of these values exists, it will be used by default.User Impact
No impact on current customers. The start_date in config is an optional input and defaults to None if left empty. Therefore, for users with existing connections, the currently existing logic resumes, whereby the connector always fetches and reads all available data during first sync.