Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't use MsSQLConfigBuilder.withSsl with strings, but instead properly named and typed methods #33261

Merged
merged 1 commit into from
Jan 4, 2024
Merged

don't use MsSQLConfigBuilder.withSsl with strings, but instead properly named and typed methods #33261

merged 1 commit into from
Jan 4, 2024

Conversation

stephane-airbyte
Copy link
Contributor

No description provided.

@vercel Vercel
Copy link

vercel bot commented Dec 8, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Dec 19, 2023 10:56pm

@stephane-airbyte Graphite App
Copy link
Contributor Author

stephane-airbyte commented Dec 8, 2023 •
edited
Loading

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@stephane-airbyte stephane-airbyte mentioned this pull request Dec 8, 2023
Merged
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 8, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

postamar
postamar reviewed Dec 12, 2023
View reviewed changes
Copy link
Contributor

@postamar postamar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM so far, thanks for doing this.

...urce-mssql/src/testFixtures/java/io/airbyte/integrations/source/mssql/MsSQLTestDatabase.java Show resolved Hide resolved
@stephane-airbyte stephane-airbyte force-pushed the stephane/12-02-fix_MssqlSource.java branch from d51a801 to e9d0acb Compare December 14, 2023 17:12
@stephane-airbyte stephane-airbyte force-pushed the stephane/12-07-don_t_use_MsSQLConfigBuilder.withSsl_with_strings_but_instead_properly_named_and_typed_methods branch from db46885 to 3d31fe6 Compare December 14, 2023 17:12
@stephane-airbyte stephane-airbyte force-pushed the stephane/12-02-fix_MssqlSource.java branch from e9d0acb to 19bf49f Compare December 19, 2023 17:27
@stephane-airbyte stephane-airbyte force-pushed the stephane/12-07-don_t_use_MsSQLConfigBuilder.withSsl_with_strings_but_instead_properly_named_and_typed_methods branch from 3d31fe6 to 9be03df Compare December 19, 2023 17:27
@stephane-airbyte stephane-airbyte mentioned this pull request Dec 19, 2023
Closed
@stephane-airbyte stephane-airbyte force-pushed the stephane/12-02-fix_MssqlSource.java branch from 19bf49f to 366b329 Compare December 19, 2023 18:00
@stephane-airbyte stephane-airbyte force-pushed the stephane/12-07-don_t_use_MsSQLConfigBuilder.withSsl_with_strings_but_instead_properly_named_and_typed_methods branch from 9be03df to 2f1f49a Compare December 19, 2023 18:00
@stephane-airbyte stephane-airbyte force-pushed the stephane/12-02-fix_MssqlSource.java branch from 366b329 to 6864da5 Compare December 19, 2023 18:19
@stephane-airbyte stephane-airbyte force-pushed the stephane/12-07-don_t_use_MsSQLConfigBuilder.withSsl_with_strings_but_instead_properly_named_and_typed_methods branch from 2f1f49a to 7e6ea3c Compare December 19, 2023 18:19
@stephane-airbyte stephane-airbyte mentioned this pull request Dec 19, 2023
Closed
@stephane-airbyte stephane-airbyte force-pushed the stephane/12-02-fix_MssqlSource.java branch from 6864da5 to bb32bf5 Compare December 19, 2023 18:22
@stephane-airbyte stephane-airbyte force-pushed the stephane/12-07-don_t_use_MsSQLConfigBuilder.withSsl_with_strings_but_instead_properly_named_and_typed_methods branch 2 times, most recently from ea56caf to f4a8334 Compare December 19, 2023 22:36
@stephane-airbyte stephane-airbyte force-pushed the stephane/12-07-don_t_use_MsSQLConfigBuilder.withSsl_with_strings_but_instead_properly_named_and_typed_methods branch from f4a8334 to 43e370e Compare December 19, 2023 22:55
@stephane-airbyte stephane-airbyte changed the base branch from stephane/12-02-fix_MssqlSource.java to master December 19, 2023 22:55
@stephane-airbyte stephane-airbyte marked this pull request as ready for review December 19, 2023 23:03
@stephane-airbyte stephane-airbyte requested a review from a team as a code owner December 19, 2023 23:03
@postamar postamar merged commit cb22376 into master Jan 4, 2024
35 of 38 checks passed
@postamar postamar deleted the stephane/12-07-don_t_use_MsSQLConfigBuilder.withSsl_with_strings_but_instead_properly_named_and_typed_methods branch January 4, 2024 17:52
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
@stephane-airbyte @jatinyadav-cc
don't use MsSQLConfigBuilder.withSsl with strings, but instead proper…
8565b88 
…ly named and typed methods (airbytehq#33261)
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
@stephane-airbyte @jatinyadav-cc
don't use MsSQLConfigBuilder.withSsl with strings, but instead proper…
0378676 
…ly named and typed methods (airbytehq#33261)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@postamar postamar postamar left review comments

@rodireich rodireich rodireich approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues connectors/source/mssql
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stephane-airbyte @rodireich @postamar @octavia-squidington-iii