Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Source Chargebee: Removes bypass for incremental acceptance tests #33388

Closed
wants to merge 2 commits into from

Conversation

pnilan
Copy link
Contributor

@pnilan pnilan commented Dec 13, 2023

What

  • Removes blanket bypass of incremental connector acceptance tests
  • Adds additional streams to future_state.json for incremental tests

How

  • Removed blanket bypass (bypass_reason)
  • Added contact, quote_line_group, and attached_item streams to future_state.json

…act', 'attached_item', and 'quote_line_group' to `future_state.json'
Copy link

vercel bot commented Dec 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Dec 13, 2023 0:32am

@octavia-squidington-iii octavia-squidington-iii added the area/connectors Connector related issues label Dec 13, 2023
Copy link
Contributor

github-actions bot commented Dec 13, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@pnilan pnilan marked this pull request as ready for review December 13, 2023 00:44
@octavia-squidington-iv octavia-squidington-iv requested review from a team December 13, 2023 00:45
Copy link
Collaborator

@lazebnyi lazebnyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pnilan
Copy link
Contributor Author

pnilan commented Jan 3, 2024

Closing as this is now included within PR #33696.

@pnilan pnilan closed this Jan 3, 2024
@pnilan pnilan deleted the pnilan/source-chargebee-incremental-tests branch October 21, 2024 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants