[ISSUE #32871] adding integration tests for UpdatedCursorIncrementalS…

[maxi297]

…tripeStream empty streams

What

Adding integration tests for all the UpdatedCursorIncrementalStripeStream that are empty streams.

How

There are two classes of UpdatedCursorIncrementalStripeStream:

• Streams that needs to rely on filtering for the events parent streams: external_account_cards and external_account_bank_accounts
• Streams that do not require filtering: payment_methods and early_fraud_warnings

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
airbyte-docs	⬜️ Ignored (Inspect)	Visit Preview		Jan 4, 2024 3:06pm

[github-actions]

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

• PR name follows PR naming conventions
• Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
• Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
• You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
• Secrets in the connector's spec are annotated with airbyte_secret
• All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
• Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
• Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
• If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

1. Check for hidden checklists in your PR description

2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

[maxi297]

I don't like the fact that this is not the real URL that is being poked but no behavior rely on this so I don't think it's worth fixing now. The same applies for external_bank_accounts.json

[girarda]

why can't we have a real request with the actual API? Is it because there's no data in our account?

[maxi297]

The concern comes from the fact that the id in "/v1/accounts/<id>/external_accounts" depends on the parent stream. However, we don't use this field in our logic so there is no need really to make sure the values are align with the parent in the test

[clnoll]

Could you add a comment explaining that here?

[maxi297]

This is JSON so I don't think I can add one specifically in this file. As it is only use in test_external_account_cards, I'll add that there

[clnoll]

Looks great! One small request.