Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source Google Ads: run decorator as a thread with timeout #33769

Merged
merged 11 commits into from
Jan 5, 2024
Merged

Source Google Ads: run decorator as a thread with timeout #33769

merged 11 commits into from
Jan 5, 2024

Conversation

roman-yermilov-gl
Copy link
Contributor

@roman-yermilov-gl roman-yermilov-gl commented Dec 23, 2023 •
edited
Loading

What

https://github.com/airbytehq/oncall/issues/3791

How

Run a read generator function in a separate thread with a specified timeout

@roman-yermilov-gl roman-yermilov-gl self-assigned this Dec 23, 2023
@vercel Vercel
Copy link

vercel bot commented Dec 23, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Jan 5, 2024 1:50am

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 23, 2023 •
edited
Loading

Warning

🚨 Connector code freeze is in effect until 2024-01-02. This PR is changing connector code. Please contact the current OC engineers if you want to merge this change to master.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 23, 2023 •
edited by roman-yermilov-gl
Loading

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@roman-yermilov-gl roman-yermilov-gl force-pushed the ryermilov/source-google-ads-run-generator-as-thread branch 3 times, most recently from c370b0a to cd5bc7f Compare December 26, 2023 20:27
@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Dec 26, 2023
@roman-yermilov-gl roman-yermilov-gl marked this pull request as ready for review December 26, 2023 20:41
@octavia-squidington-iv octavia-squidington-iv requested a review from a team December 26, 2023 20:42
@roman-yermilov-gl roman-yermilov-gl force-pushed the ryermilov/source-google-ads-run-generator-as-thread branch from 318c445 to 7295bd5 Compare January 4, 2024 01:25
@roman-yermilov-gl roman-yermilov-gl force-pushed the ryermilov/source-google-ads-run-generator-as-thread branch from 14f59c6 to af7965c Compare January 4, 2024 02:35
@roman-yermilov-gl roman-yermilov-gl force-pushed the ryermilov/source-google-ads-run-generator-as-thread branch from 94f4d22 to b60a202 Compare January 5, 2024 00:00
@roman-yermilov-gl roman-yermilov-gl merged commit d3cbc6a into master Jan 5, 2024
24 checks passed
@roman-yermilov-gl roman-yermilov-gl deleted the ryermilov/source-google-ads-run-generator-as-thread branch January 5, 2024 13:49
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
@roman-yermilov-gl @jatinyadav-cc
Source Google Ads: run decorator as a thread with timeout (airbytehq#…
c634c5c 
…33769)
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
@roman-yermilov-gl @jatinyadav-cc
Source Google Ads: run decorator as a thread with timeout (airbytehq#…
7af1682 
…33769)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tolik0 tolik0 tolik0 approved these changes

@bazarnov bazarnov bazarnov approved these changes

@lazebnyi lazebnyi Awaiting requested review from lazebnyi

@brianjlai brianjlai Awaiting requested review from brianjlai

@alafanechere alafanechere Awaiting requested review from alafanechere

Assignees

@roman-yermilov-gl roman-yermilov-gl

Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/google-ads
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@roman-yermilov-gl @bazarnov @tolik0 @octavia-squidington-iii